adr: avoid submitting while IME composition is active - #140
Open
foxytanuki wants to merge 1 commit into
Open
Conversation
foxytanuki
marked this pull request as ready for review
August 2, 2026 23:59
foxytanuki
force-pushed
the
fix/web-composer-ime
branch
from
August 3, 2026 00:09
496aa28 to
a361dec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this while using QM with Japanese input: Enter used to confirm an IME conversion can submit partial text and leave the rest in the composer.
The short proposal is in
adrs/web-composer-ime.md. I originally opened this as an implementation PR before noticing the contribution guidance, so I changed this PR to the informal proposal instead.The tested implementation is preserved on
foxytanuki:hotfix/web-composer-imeif it's useful later.