Skip to content

adr: avoid submitting while IME composition is active #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
foxytanuki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adr: avoid submitting while IME composition is active #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions adrs/web-composer-ime.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
I've been using QM with Japanese input and found that pressing Enter to confirm an IME conversion can submit the message early. This sometimes sends half-finished text and leaves the rest in the composer.

I think the web composer should ignore Enter while IME composition is active, then let the next normal Enter submit the completed text. Safari's `keyCode === 229` behavior probably needs to be covered too.

I tested this behavior with normal messages and mid-run steering on our deployment. Japanese input worked as expected, while English Enter and Shift+Enter kept their existing behavior. I also have a tested implementation in the preserved [`hotfix/web-composer-ime`](https://github.com/foxytanuki/qm/tree/hotfix/web-composer-ime) branch if that's useful.