adr: require SPRITES_TOKEN on fresh fly deploys - #145
Open
MrTig-afk wants to merge 2 commits into
Open
Conversation
rajpratham1
suggested changes
Aug 3, 2026
rajpratham1
left a comment
rajpratham1
left a comment
There was a problem hiding this comment.
The underlying issue appears valid, but the document is too brief to serve as an Architecture Decision Record and lacks the rationale and consequences needed for long-term documentation
|
+1, hit this on the docker target this week. The SPRITES_TOKEN requirement keys off env.core.SANDBOX_BACKEND, but declaring the typed config field sandbox.backend: "sprites" does NOT add it to the computed secret set ... qm check passes green, then core crash-loops at boot with "missing or insecure required core secrets: SPRITES_TOKEN". Two spellings of the same, but one carries the secret requirement. Perhaps the validation this ADR adds can key off the resolved backend |
16francej
added
adr
cdolan-personal confirmed the same crash on the docker target via the typed sandbox.backend field, so patching only the fly defaults table is too narrow. Claude-Session: https://claude.ai/code/session_01BNMpRpMFpLfTxS8LLzu4JD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note in adrs/ per CONTRIBUTING, for #130.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.