Skip to content

adr: require SPRITES_TOKEN on fresh fly deploys #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrTig-afk wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −0
Open

adr: require SPRITES_TOKEN on fresh fly deploys #145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
297df98
add adr proposing the fly SPRITES_TOKEN fix
MrTig-afk Aug 3, 2026
a446db0
broaden the proposal to key off the resolved backend
MrTig-afk Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions adrs/fly-sprites-token.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Fresh fly deploys crash-loop with no warning: the CLI's secret check never
sees the sprites backend value the runtime derives, so it never asks for
SPRITES_TOKEN.

Update after PR feedback: cdolan-personal hit the same crash on the
docker target — setting the typed sandbox.backend: "sprites" field doesn't
register the requirement either, since the check only reads the raw env
var. So instead of just adding the missing entry to the fly defaults
table like the AWS one has, the fix I'd propose is keying the
SPRITES_TOKEN requirement off the resolved backend, so every target is
covered. Still worth checking if other secrets have the same blind spot.

Context: https://github.com/yc-software/qm/issues/130 and the comments on
this PR.