(pre-review) [framework] introduce private entry function for creating multisig account#1
Open
(pre-review) [framework] introduce private entry function for creating multisig account#1
Conversation
Co-authored-by: gedigi <[email protected]>
* temp * update CI action
…ublish) (aptos-labs#13344) * added Large Package Publishing e2e move test cases * updated `large_packages.move` contract to support object code deployment and use SmartTable to store code in StagingArea * added `--chunked-publish` option to the CLI for 1) account deploy 2) object deploy 3) object upgrade * added `aptos move clear-staging-area` command * added a new error type: `PackageSizeExceeded` * updated CLI docs and output messages for the chunked publish mode
* doc for enum * add tests
Adds a couple of lint checks to check and suggest removing needless ref-deref and deref-ref pairs.
To better handle large transactions
* Add support for a test federated oidc provider * update * fmt
…tos-labs#13917) * Added check for max fields, similar to what `add_fungibility` does. * FA tests for mutable metadata had too long of symbol length. * FA tests for mutable metadata had too long of symbol length. * Added new expecting-failure tests for each `mutate_metadata` parameter.
…ks to include enum variant field access (aptos-labs#14587)
* Add an entry function to update the federated jwkset * make it an entry func * update * update md * update func doc * Update aptos-move/framework/aptos-framework/sources/jwks.move Co-authored-by: Greg Nazario <[email protected]> * update docs --------- Co-authored-by: Greg Nazario <[email protected]>
…14609) * fix dot exp for index notation * move_pr.sh -i2 test * add comment
gregnazario
reviewed
Sep 13, 2024
Comment on lines
574
to
579
There was a problem hiding this comment.
I would note here, also objects, don't prevent this as well.
Owner
Author
There was a problem hiding this comment.
specifically speaking things like ExtendRef can still exist for object account I assume that's what you're saying?
There was a problem hiding this comment.
tests don't have to be entry or public, guess it's kinda funny the ones in this file are set like that prior your changes.
Owner
Author
There was a problem hiding this comment.
for this pr i'll just go with the file's convention, think it's better for someone to change those as part of a refactoring commit
* add e2e move test for federated keyless * Use entry function instead of script to install JWKs --------- Co-authored-by: Oliver <[email protected]>
Test Plan: running on PR, step should upload results and not fail the job either way
* [ts-sdk] Remove V1 SDK * [CI] Remove TS SDK E2E tests * [api] Update readme to not refer to legacy TS SDK * [refactor] Remove ts-sdk more * [refactor] Deprecate rest of SDK v1
Ensure that the following functions are publicly visible so they can be used from the `move-mutation-test` tool. - `aptos::move_tool::aptos_debug_natives::aptos_debug_natives()` - `aptos::move_tool::experiments_from_opt_level()`
…abs#14686) * Automatically bump Forge compat base image to latest release ---------
…aptos-labs#14765) Co-authored-by: Zac Yang <[email protected]>
…ied and unverified signatures. (aptos-labs#14641)
aptos-labs#14763) * added gcloud sdk and kubectl in the packer, uploaded the image in to ci aws account, changed the ami in workflows --------- Co-authored-by: Zac Yang <[email protected]>
* [gha] fix cargo metadata syntax error * [gha] cargo metadata uploader uses gcloud storage
yeptos
force-pushed
the
multisig-v2-create-from-existing-signer
branch
2 times, most recently
from
449e4ac to
3b7e10f
Compare
Co-authored-by: gedigi <[email protected]>
…ptos-labs#14569) * script transaction * modify the output path by append the network name --------- Co-authored-by: yuunlimm <[email protected]>
…count This eliminates the need for generating the complex proof the existing create_with_existing_account functions require.
sherry-x
force-pushed
the
multisig-v2-create-from-existing-signer
branch
from
9b812ec to
524333a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates the need for generating the complex proof the existing create_with_existing_account functions require.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist