(pre-review) [framework] introduce private entry function for creating multisig account

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,6 +1,20 @@
 ## Description
 <!-- Please include a summary of the change, including which issue it fixes or what feature it adds. Include relevant motivation, context and documentation as appropriate. List dependencies that are required for this change, if any. -->
 
+## How Has This Been Tested?
+<!--
+- Please ensure that the functionality introduced by this change is well tested and verified to work as expected.
+- Ensure tests cover both happy and unhappy paths.
+- List and link relevant tests.
+-->
+
+## Key Areas to Review
+<!--
+- Identify any critical parts of the code that require special attention or understanding. Explain why these parts are crucial to the functionality or architecture of the project.
+- Point out any areas where complex logic has been implemented. Provide a brief explanation of the logic and your approach to make it easier for reviewers to follow.
+- Highlight any areas where you are particularly concerned or unsure about the code's impact on the change. This can include potential performance or security issues, or compatibility with existing features.
+-->
+
 ## Type of Change
 - [ ] New feature
 - [ ] Bug fix
@@ -18,22 +32,9 @@
 - [ ] Aptos Framework
 - [ ] Aptos CLI/SDK
 - [ ] Developer Infrastructure
+- [ ] Move Compiler
 - [ ] Other (specify)
 
-## How Has This Been Tested?
-<!--
-- Please ensure that the functionality introduced by this change is well tested and verified to work as expected.
-- Ensure tests cover both happy and unhappy paths.
-- List and link relevant tests.
--->
-
-## Key Areas to Review
-<!--
-- Identify any critical parts of the code that require special attention or understanding. Explain why these parts are crucial to the functionality or architecture of the project.
-- Point out any areas where complex logic has been implemented. Provide a brief explanation of the logic and your approach to make it easier for reviewers to follow.
-- Highlight any areas where you are particularly concerned or unsure about the code's impact on the change. This can include potential performance or security issues, or compatibility with existing features.
--->
-
 ## Checklist
 - [ ] I have read and followed the [CONTRIBUTING](https://github.com/aptos-labs/aptos-core/blob/main/CONTRIBUTING.md) doc
 - [ ] I have performed a self-review of my own code

.github/actions/determine-or-use-target-branch-and-get-last-released-image/action.yaml

@@ -0,0 +1,88 @@
+name: "Determine or Use Target Branch and Get Latest Docker Image"
+description: |
+  Determine the branch to fetch the latest docker image tag from, or use a target branch directly.
+  - If base-branch is set, determine the target branch to fetch the latest docker image tag from
+    - Determine the IMAGE_TAG based on the latest release R and check for images built on branch R - 1:
+      - For commits on the aptos-release-v1.19 branch, the IMAGE_TAG should be the latest commit built on aptos-release-v1.18
+      - For commits on the main branch, the IMAGE_TAG should be the latest commit on the max release aptos-release-v<X.X> branch
+      - For commits on other branches, the IMAGE_TAG should be the latest commit on the branch's last release aptos-release-v<X.X> branch
+  - If branch is set, use it directly
+
+inputs:
+  base-branch:
+    description: "The base branch to determine the target from, or use a target branch directly"
+    required: false
+  branch:
+    description: "Use this branch directly if set"
+    required: false
+  variants:
+    description: "The variants to check, as a space-separated string, e.g. 'performance failpoints'"
+    required: false
+
+outputs:
+  TARGET_BRANCH:
+    description: "The determined or target target branch"
+    value: ${{ steps.set-target-branch.outputs.TARGET_BRANCH }}
+  IMAGE_TAG:
+    description: "The latest docker image tag for the given branch and variants"
+    value: ${{ steps.determine-test-image-tag.outputs.IMAGE_TAG }}
+
+runs:
+  using: composite
+  steps:
+    # Checkout repository based on base branch or target branch
+    - name: Checkout branch
+      uses: actions/checkout@v4
+      with:
+        ref: ${{ inputs.base-branch || inputs.branch }}
+        path: checkout_branch
+        fetch-depth: 0
+
+    - name: Setup Python environment
+      uses: ./checkout_branch/.github/actions/python-setup
+      with:
+        pyproject_directory: checkout_branch/testsuite
+
+    # Determine the target branch if base-branch is used
+    - name: Set target branch
+      id: set-target-branch
+      run: |
+        if [[ -n "${{ inputs.base-branch }}" ]]; then
+          base_branch="${{ inputs.base-branch }}"
+          echo "Determining target branch from base branch: $base_branch"
+          ./testrun determine_target_branch_to_fetch_last_released_image.py "$base_branch"
+        else
+          echo "Using target branch: ${{ inputs.branch }}"
+          echo "TARGET_BRANCH=${{ inputs.branch }}" >> $GITHUB_OUTPUT
+        fi
+      shell: bash
+      working-directory: checkout_branch/testsuite
+
+    # Checkout the determined or target branch
+    - name: Checkout target branch
+      if: ${{ steps.set-target-branch.outputs.TARGET_BRANCH != inputs.branch }}
+      uses: actions/checkout@v4
+      with:
+        ref: ${{ steps.set-target-branch.outputs.TARGET_BRANCH }}
+        path: checkout_branch
+        fetch-depth: 0
+
+    # Setup Python environment again after second checkout, as branches are different
+    - name: Setup Python environment again
+      if: ${{ steps.set-target-branch.outputs.TARGET_BRANCH != inputs.branch }}
+      uses: ./checkout_branch/.github/actions/python-setup
+      with:
+        pyproject_directory: checkout_branch/testsuite
+
+    # Determine image tag using the target branch
+    - name: Determine image tag
+      id: determine-test-image-tag
+      run: |
+        variants=(${{ inputs.variants }}) # split the variants string into an array
+        variants_args=()
+        for variant in "${variants[@]}"; do
+          variants_args+=("--variant" "$variant")
+        done
+        ./testrun find_latest_image.py "${variants_args[@]}"
+      shell: bash
+      working-directory: checkout_branch/testsuite

.github/actions/general-lints/action.yaml

@@ -16,27 +16,3 @@ runs:
         sudo apt-get install shellcheck --assume-yes --no-install-recommends
         shellcheck scripts/dev_setup.sh
       shell: bash
-
-    # Run the python lints and tests
-    - name: Run python lints and tests
-      uses: ./.github/actions/python-lint-tests
-
-    # Setup node
-    - name: Setup node
-      uses: actions/setup-node@v3
-      with:
-        node-version-file: .node-version
-
-    # Setup pnpm
-    - name: Setup pnpm
-      uses: pnpm/action-setup@v4
-
-    # Install packages for examples and run package build, lint and tests
-    - name: Run ecosystem lint
-      run: |
-        cd ./ecosystem/typescript/sdk/examples/typescript && pnpm install && cd -
-        cd ./ecosystem/typescript/sdk/examples/javascript && pnpm install && cd -
-        cd ./ecosystem/typescript/sdk && pnpm install && cd -
-        cd ./ecosystem/typescript/sdk && pnpm lint && cd -
-        cd ./ecosystem/typescript/sdk && pnpm fmt:check && cd -
-      shell: bash

.github/actions/get-latest-docker-image-tag/action.yml

@@ -18,7 +18,7 @@ outputs:
 runs:
   using: composite
   steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         ref: ${{ inputs.branch }}
         path: checkout_branch

.github/actions/move-prover-setup/action.yaml

@@ -14,7 +14,7 @@ runs:
     # rust-cache action will cache ~/.cargo and ./target
     # https://github.com/Swatinem/rust-cache#cache-details
     - name: Run cargo cache
-      uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # pin@v2.2.0
+      uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # pin@v2.7.3
 
     - name: install related tools and prover dependencies
       shell: bash

.github/actions/rust-setup/action.yaml

@@ -20,7 +20,7 @@ runs:
     # rust-cache action will cache ~/.cargo and ./target
     # https://github.com/Swatinem/rust-cache#cache-details
     - name: Run cargo cache
-      uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # pin@v2.2.0
+      uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # pin@v2.7.3
       with:
         key: ${{ inputs.ADDITIONAL_KEY }}
 

.github/actions/rust-unit-tests/action.yaml

@@ -4,6 +4,9 @@ inputs:
   GIT_CREDENTIALS:
     description: "Optional credentials to pass to git. Useful if you need to pull private repos for dependencies"
     required: false
+  TRUNK_API_TOKEN:
+    description: "Api key for uploading test results to trunk.io"
+    required: false
 
 runs:
   using: composite
@@ -28,11 +31,22 @@ runs:
     # Run the rust unit tests
     - name: Run all unit tests
       run: |
-        NEXTEST_EXPERIMENTAL_LIBTEST_JSON=1 cargo nextest run --profile ci --cargo-profile ci --locked --workspace --exclude smoke-test --exclude aptos-testcases --exclude aptos-keyless-circuit --retries 3 --no-fail-fast --message-format libtest-json > nextest_output.json || python3 .github/actions/rust-unit-tests/nextest_summary.py nextest_output.json "$GITHUB_STEP_SUMMARY" -f
+        cargo nextest run \
+          --profile ci \
+          --cargo-profile ci \
+          --locked \
+          --workspace \
+          --exclude smoke-test \
+          --exclude aptos-testcases \
+          --exclude aptos-keyless-circuit \
+          --retries 3 \
+          --no-fail-fast \
+          --message-format libtest-json > nextest_output.json || python3 .github/actions/rust-unit-tests/nextest_summary.py nextest_output.json "$GITHUB_STEP_SUMMARY" -f
         python3 .github/actions/rust-unit-tests/nextest_summary.py nextest_output.json "$GITHUB_STEP_SUMMARY" || echo "summary generation had an error"
         rm nextest_output.json
       shell: bash
       env:
+        NEXTEST_EXPERIMENTAL_LIBTEST_JSON: 1
         INDEXER_DATABASE_URL: postgresql://postgres@localhost/postgres
         RUST_MIN_STACK: "4297152"
         MVP_TEST_ON_CI: "true"
@@ -41,3 +55,14 @@ runs:
         CVC5_EXE: /home/runner/bin/cvc5
         DOTNET_ROOT: /home/runner/.dotnet
         BOOGIE_EXE: /home/runner/.dotnet/tools/boogie
+
+    - name: Upload results
+      # Run this step even if the test step ahead fails
+      if: "!cancelled() && ${{ inputs.TRUNK_API_TOKEN }}"
+      uses: trunk-io/analytics-uploader@main
+      with:
+        # Configured in the nextest.toml file
+        junit-paths: target/nextest/ci/junit.xml
+        org-slug: aptoslabs
+        token: ${{ inputs.TRUNK_API_TOKEN }}
+      continue-on-error: true

.github/runs-on.yml

@@ -2,7 +2,8 @@ images:
   aptos-ubuntu-x64:
     platform: "linux"
     arch: "x64"
-    ami: "ami-07ce6402e4a205d44"
+    ami: "ami-09f7d4bfb08b771be" # image for testing, with gcloud sdk and kubectl
+    owner: "058264343338" # aptos-ci AWS account id
   aptos-ubuntu-x64-latest:
     platform: "linux"
     arch: "x64"

.github/workflows/aptos-node-release.yaml

@@ -19,7 +19,7 @@ jobs:
   release-aptos-node:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ inputs.branch }}
 

.github/workflows/cargo-metadata-upload.yaml

@@ -11,7 +11,7 @@ permissions:
   id-token: write
 jobs:
   cargo-metadata:
-    runs-on: ubuntu-latest
+    runs-on: runs-on,cpu=4,ram=16,family=m7a+m7i-flex,image=aptos-ubuntu-x64,run-id=${{ github.run_id }},spot=co
     steps:
       - uses: actions/checkout@v4
       - uses: dsherret/rust-toolchain-file@v1
@@ -20,7 +20,7 @@ jobs:
         with:
           workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
           service_account: ${{ secrets.GCP_SERVICE_ACCOUNT_EMAIL }}
-      - uses: "google-github-actions/setup-gcloud@v2"
       - shell: bash
         run: |
-          cargo metadata --all-features | gsutil cp - gs://aptos-core-cargo-metadata-public/metadata-${{ github.sha }}.json
+          set -ex
+          cargo metadata --all-features | gcloud storage cp - gs://aptos-core-cargo-metadata-public/metadata-${{ github.sha }}.json