Skip to content

Conversation

mspirkov
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #20622

@mspirkov mspirkov marked this pull request as ready for review October 17, 2025 12:26
@mspirkov
Copy link
Contributor Author

@terabytesoftw take a look, please

@terabytesoftw
Copy link
Member

terabytesoftw commented Oct 17, 2025

@terabytesoftw take a look, please

This is great, i would just change the Docker version to PHP-Yii2 8.4, since in the README.md we recommend using 8+, otherwise it looks fine.

@terabytesoftw terabytesoftw linked an issue Oct 17, 2025 that may be closed by this pull request
@mspirkov
Copy link
Contributor Author

Thanks! I'll fix it

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samdark samdark merged commit f9c1c1d into yiisoft:master Oct 19, 2025
129 of 130 checks passed
@samdark
Copy link
Member

samdark commented Oct 19, 2025

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local test execution tools are broken

4 participants