feat(config): add JQ_COLORS environment variable support #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced JqColors struct to handle JQ_COLORS parsing - Updated ConfigContentStyle to support conversion from &str - Modified Config default implementation to use JQ_COLORS - Added tests for JqColors parsing and ConfigContentStyle conversion - Updated ConfigFile to use ConfigContentStyle instead of ContentStyle - Updated Config to use CrosstermContentStyle instead of ContentStyle - Added JqColors parsing from environment variable in Config default
The CI workflow is now triggered on both push and pull_request events. This ensures that tests are run for both direct pushes and pull requests, improving the reliability of the codebase.
Removed the redundant map_err call in the write_default_config condition within the main function.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This would be respected when the default configuration file is created as part of #70 but after, the configuration file would take precedence.
Note
Boolean is considered a single value currently, but JQ treats
falseandtrueas different. I'm choosing to usetrueonly at the moment.Screen.Recording.2025-03-02.at.16.50.30.mov