-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onDeepLink EventHandler to h5vcc_runtime IDL #4993
Add onDeepLink EventHandler to h5vcc_runtime IDL #4993
Conversation
Working on the web test. |
c4bea6d
to
079eee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good! A few comments here and there.
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/deep_link_event.cc
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/deep_link_event.h
Outdated
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/deep_link_event.idl
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/h_5_vcc_runtime.h
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/h_5_vcc_runtime.cc
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/h_5_vcc_runtime.cc
Show resolved
Hide resolved
...party/blink/web_tests/wpt_internal/h5vcc/h5vcc-runtime/h5vcc-runtime-onDeepLink.https.any.js
Outdated
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/h_5_vcc_runtime.cc
Outdated
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/h_5_vcc_runtime.idl
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/h_5_vcc_runtime.idl
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't oppose these changes anymore but I'll ask for another pass at the JS test 🙏
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/h_5_vcc_runtime.cc
Show resolved
Hide resolved
...arty/blink/web_tests/wpt_internal/cobalt/h5vcc-runtime/h5vcc-runtime-onDeepLink.https.any.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two minor comments but otherwise lgtm, thanks!
third_party/blink/renderer/modules/cobalt/h5vcc_runtime/h_5_vcc_runtime.h
Show resolved
Hide resolved
Would this type of event handler change be what we follow for all of our event handlers? I.e. would the signature for H5vccRuntime.onPause end up changing a similar way? |
@zhongqiliang I'm seeing a crash on a devel linux build at https://github.com/youtube/cobalt/blob/main/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc#L77, related to |
#4993 can crash the app with this error. Abort message: '[15412:15479:0304/132646.498142:FATAL:trusted_type_policy_factory.cc(77)] Check failed: String(entry.attribute).LowerASCII() == entry.attribute ("ondeeplink" vs. onDeepLink)' b/374147993
Sample javascript code for register the onDeepLink callback.
Tested on devtools. https://screenshot.googleplex.com/AymzZtjCxUYZg2G
b/374147993