[media] Move StarboardRenderer to MojoRenderer #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
sbplayer_in_gpu
branch
10 times, most recently
from
10d7c58 to
3acdba0
Compare
borongc
force-pushed
the
sbplayer_in_gpu
branch
6 times, most recently
from
aa08231 to
0db7fab
Compare
borongc
force-pushed
the
sbplayer_in_gpu
branch
from
0db7fab to
f3bdc98
Compare
yell0wd0g
requested changes
Mar 25, 2025
borongc
force-pushed
the
sbplayer_in_gpu
branch
from
f3bdc98 to
f16500a
Compare
borongc
force-pushed
the
sbplayer_in_gpu
branch
5 times, most recently
from
197faeb to
61e88ba
Compare
yell0wd0g
approved these changes
Mar 26, 2025
borongc
force-pushed
the
sbplayer_in_gpu
branch
4 times, most recently
from
16af8d2 to
598a006
Compare
Move StarboardRenderer to Gpu thread, and each of StarboardRenderer is ran on PooledSingleThreadTaskRunner. This allows Starboard to access Chrome_InProcGpuThread for graphical tasks. b/394368542
borongc
force-pushed
the
sbplayer_in_gpu
branch
from
598a006 to
2b4239d
Compare
osagie98
approved these changes
Mar 27, 2025
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
Move StarboardRenderer to Gpu thread, and each of StarboardRenderer is ran on PooledSingleThreadTaskRunner. This allows Starboard to access `Chrome_InProcGpuThread` for graphical tasks. This PR adds a `CreateStarboardRenderer()` to the InterfaceFactory mojom with the purpose of running StarboardRenderer on Gpu thread; this forced an implementation in a number of places, namely MediaInterfaceFactory, MediaInterfaceProxy and FramelessMediaInterfaceProxy. b/394368542 b/378740140 b/405401569 (cherry picked from commit df40583)
borongc
added a commit
that referenced
this pull request
Mar 28, 2025
…5228) Refer to the original PR: #5113 Move StarboardRenderer to Gpu thread, and each of StarboardRenderer is ran on PooledSingleThreadTaskRunner. This allows Starboard to access `Chrome_InProcGpuThread` for graphical tasks. This PR adds a `CreateStarboardRenderer()` to the InterfaceFactory mojom with the purpose of running StarboardRenderer on Gpu thread; this forced an implementation in a number of places, namely MediaInterfaceFactory, MediaInterfaceProxy and FramelessMediaInterfaceProxy. b/394368542 b/378740140 b/405401569 Co-authored-by: Bo-Rong Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move StarboardRenderer to Gpu thread, and each of StarboardRenderer is ran on PooledSingleThreadTaskRunner. This allows Starboard to access
Chrome_InProcGpuThreadfor graphical tasks.This PR adds a
CreateStarboardRenderer()to the InterfaceFactory mojom with the purpose of running StarboardRenderer on Gpu thread; this forced an implementation in a number of places, namely MediaInterfaceFactory, MediaInterfaceProxy and FramelessMediaInterfaceProxy.b/394368542
b/378740140
b/405401569