Skip to content

Make it possible to build with the "circuit" feature for no_std targets #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daira
Copy link
Contributor

@daira daira commented Mar 19, 2025

Currently failing. This is basically blocked on the update to rand 0.9.

@daira daira force-pushed the ci-add-circuit-feature-for-no_std branch 4 times, most recently from dc95cec to f0e2771 Compare March 19, 2025 12:09
@daira daira changed the title CI: add --features circuit for no_std platforms, and rename that step to build-nostd CI: add --features circuit for no_std targets, and rename that step to build-nostd Mar 19, 2025
@daira daira force-pushed the ci-add-circuit-feature-for-no_std branch 2 times, most recently from 199a746 to ea90f18 Compare March 19, 2025 12:36
@daira daira changed the title CI: add --features circuit for no_std targets, and rename that step to build-nostd Make it possible to build with the "circuit" feature for no_std targets Mar 19, 2025
@daira daira force-pushed the ci-add-circuit-feature-for-no_std branch 3 times, most recently from e1e731a to 10c39a2 Compare March 19, 2025 13:35
@daira daira marked this pull request as draft March 19, 2025 13:35
@daira daira force-pushed the ci-add-circuit-feature-for-no_std branch 5 times, most recently from 85b1caa to 3b6b9a6 Compare March 19, 2025 14:10
@daira
Copy link
Contributor Author

daira commented Mar 19, 2025

This is harder than I thought, and will require releases of at least pasta_curves and the halo2 crates (to avoid std dependencies via rand_core). Going to leave this on the back burner for now.

@daira daira force-pushed the ci-add-circuit-feature-for-no_std branch from 3b6b9a6 to b2252da Compare March 19, 2025 15:11
@daira daira force-pushed the ci-add-circuit-feature-for-no_std branch from b2252da to aa254e7 Compare March 19, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant