Skip to content

Conversation

@TheJulianJES
Copy link
Collaborator

Proposed change

Combine Third Reality temperature & humidity sensor v2 quirks from these PRs:

Additional information

FYI @3reality-support for how this works with similar quirks and .clone().
If the devices need to be split again, we can always do that in the future. But as long as some quirks can be combined, we should do that.

Future

I'll follow up with another PR with some more changes (removing Fahrenheit offset, as Celsius should be enough).
Home Assistant will change the unit on the temperature offset when the temperature device class is set.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

@TheJulianJES TheJulianJES added the code quality Improvement to code quality label Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.18%. Comparing base (2f6046e) to head (e9c8fc6).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4441      +/-   ##
==========================================
- Coverage   92.19%   92.18%   -0.01%     
==========================================
  Files         366      365       -1     
  Lines       12012    12001      -11     
==========================================
- Hits        11074    11063      -11     
  Misses        938      938              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES merged commit 5a1de36 into zigpy:dev Oct 28, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improvement to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant