Remove Fahrenheit temperature offset for Third Reality sensors #4442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This no longer exposes the Fahrenheit temperature offset for Third Reality temperature and humidity sensors.
HA should automatically present the unit the user prefers when the temperature device class is set for a temperature entity, which I added in the initial PRs, where the sensors where added, making the additional Fahrenheit entity unnecessary.
For the LCD sensors at least, it makes sense to expose the temperature offset that the device offers, as all template options in HA wouldn't change the temperature displayed on the device.
Why this was merged in the first place
Initially, I thought that this was just a weird device implementation, where the "Fahrenheit offset" only applies to the LCD sensor if it's in "Fahrenheit" mode (can be switched with the side button on the device).
But from the fact that non-LCD sensors also include the Fahrenheit correction and by interpreting more into existing PR descriptions, I think the "Fahrenheit" offset is just to make it easier for the user.
But we don't need to rely on the device doing this with two separate entities, as HA already does this with device classes changing the unit per user preference.
Other change
ThirdRealityTemperatureAndHumidityClustercluster class is also renamed toThirdRealityCluster. Both names aren't ideal, but this is a pure manufacturer/private cluster. The latter is at least much shorter.Additional information
Follow-up to (PRs which added both Celsius and Fahrenheit offset):
Related (soil sensor with similar offset attributes):
Checklist
pre-commitchecks pass / the code has been formatted using Black