Skip to content

Remove Fahrenheit temperature offset for Third Reality sensors #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

Remove Fahrenheit temperature offset for Third Reality sensors #4442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 15 additions & 26 deletions zhaquirks/thirdreality/temperature_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,63 +10,52 @@
from zigpy.zcl.foundation import BaseAttributeDefs, ZCLAttributeDef


class ThirdRealityTemperatureAndHumidityCluster(CustomCluster):
class ThirdRealityCluster(CustomCluster):
"""Third Reality's temperature and humidity sensor private cluster."""

cluster_id = 0xFF01

class AttributeDefs(BaseAttributeDefs):
"""Define the attributes of a private cluster."""

temperature_correction_fahrenheit: Final = ZCLAttributeDef(
id=0x0033,
temperature_offset_celsius: Final = ZCLAttributeDef(
id=0x0031,
type=t.int16s,
is_manufacturer_specific=True,
)

temperature_correction_celsius: Final = ZCLAttributeDef(
id=0x0031,
humidity_offset: Final = ZCLAttributeDef(
id=0x0032,
type=t.int16s,
is_manufacturer_specific=True,
)

humidity_correction: Final = ZCLAttributeDef(
id=0x0032,
# intentionally not exposed as an entity
temperature_offset_fahrenheit: Final = ZCLAttributeDef(
id=0x0033,
type=t.int16s,
is_manufacturer_specific=True,
)


base_quirk = (
QuirkBuilder()
.replaces(ThirdRealityTemperatureAndHumidityCluster)
.replaces(ThirdRealityCluster)
.number(
attribute_name=ThirdRealityTemperatureAndHumidityCluster.AttributeDefs.temperature_correction_celsius.name,
cluster_id=ThirdRealityTemperatureAndHumidityCluster.cluster_id,
attribute_name=ThirdRealityCluster.AttributeDefs.temperature_offset_celsius.name,
cluster_id=ThirdRealityCluster.cluster_id,
min_value=-10000,
max_value=10000,
multiplier=0.01,
step=0.1,
device_class=NumberDeviceClass.TEMPERATURE,
unit=UnitOfTemperature.CELSIUS,
translation_key="temperature_offset_celsius",
fallback_name="Celsius offset",
)
.number(
attribute_name=ThirdRealityTemperatureAndHumidityCluster.AttributeDefs.temperature_correction_fahrenheit.name,
cluster_id=ThirdRealityTemperatureAndHumidityCluster.cluster_id,
min_value=-10000,
max_value=10000,
multiplier=0.01,
step=0.1,
device_class=NumberDeviceClass.TEMPERATURE,
unit=UnitOfTemperature.FAHRENHEIT,
translation_key="temperature_offset_fahrenheit",
fallback_name="Fahrenheit offset",
translation_key="temperature_offset",
fallback_name="Temperature offset",
)
.number(
attribute_name=ThirdRealityTemperatureAndHumidityCluster.AttributeDefs.humidity_correction.name,
cluster_id=ThirdRealityTemperatureAndHumidityCluster.cluster_id,
attribute_name=ThirdRealityCluster.AttributeDefs.humidity_offset.name,
cluster_id=ThirdRealityCluster.cluster_id,
min_value=-10000,
max_value=10000,
multiplier=0.01,
Expand Down
Loading