Verify cover supported features per window covering type #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct window_covering_type
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #410 +/- ##
==========================================
+ Coverage 96.69% 96.70% +0.01%
==========================================
Files 61 61
Lines 9863 9867 +4
==========================================
+ Hits 9537 9542 +5
+ Misses 326 325 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…current_position properties
jeverley
force-pushed
the
cover-handle-lift-only-devices-reporting-tilt-position
branch
from
90f300b to
aab8119
Compare
Apply pre-commit auto fixes
jeverley
force-pushed
the
cover-handle-lift-only-devices-reporting-tilt-position
branch
from
aab8119 to
d9cfa64
Compare
jeverley
changed the title
jeverley
changed the title
- Also use them in the tests rather than defining them separately
jeverley
force-pushed
the
cover-handle-lift-only-devices-reporting-tilt-position
branch
from
dc502ce to
5953d0f
Compare
puddly
reviewed
Apr 8, 2025
puddly
reviewed
Apr 8, 2025
jeverley
added a commit
to jeverley/zha
that referenced
this pull request
Apr 9, 2025
…e HA cache This adds a timeout for movement states restored from the entity cache. Uses zigpy#410 as a base.
TheJulianJES
changed the title
puddly
pushed a commit
to jeverley/zha
that referenced
this pull request
Apr 15, 2025
…e HA cache This adds a timeout for movement states restored from the entity cache. Uses zigpy#410 as a base.
jeverley
added a commit
to jeverley/zha
that referenced
this pull request
Apr 23, 2025
…e HA cache This adds a timeout for movement states restored from the entity cache. Uses zigpy#410 as a base.
puddly
pushed a commit
that referenced
this pull request
Apr 29, 2025
* Refresh cover state after the default timeout after restoring from the HA cache This adds a timeout for movement states restored from the entity cache. Uses #410 as a base. * Implement checks to ensure a movement state is not restored if the device has already reached the movement extrema - Updates tests to use a common mock cover device creation function to reduce code repetition * Remove `_is_completely_open` property and init `_state` with None - We init `_state` with None and let the `_determine_cover_state` function populate the value from current positions - Ensures all lines are coverable by tests * Ensure cover state restore and transition timer handles are cancelled upon entity removal * Add tests for on_remove timer cancellations * Make use of clear_transition methods to cancel timers on removal * Test cleanup * Add annotations for async_update test * Consolidate cover calls to `maybe_emit_state_changed_event` into `_determine_cover_position` function * Ensure position attributes are still updated when the state doesn't change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
current_positionandcurrent_tilt_positionstate attributes now reportNoneif their features are not supported by the device, resolves #142352supported_featureslogic so it excludes tilt only window covering types when enabling lift featureswindow_covering_typeattribute value is undefined by the deviceWCT.ShutterorWCT.Tilt_blind_tilt_onlytypes, see Table 7-41. Window Covering Type from the Cluster Library Specification 07-5123 Revision 8current_tilt_positionis always Nonecurrent_positionis always NoneFixes issue
Zigbee Soma Smart Shades 3 covers report OPEN state when closed home-assistant/core#142352
Related
FYI @TheJulianJES, @puddly, @dmulcahey