[CP Staging] Patch Skia to fix iOS chart crash and charts stuck loading - #98437
Conversation
|
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
mountiny
left a comment
There was a problem hiding this comment.
Thanks! good that this is already upstream so we can remove it soon
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-08-12.18.16.40.movAndroid: mWeb ChromeiOS: mWeb SafariMacOS: Chrome / Safari |
roryabraham
left a comment
There was a problem hiding this comment.
Drop this patch once the Skia dependency is bumped to >= 2.6.9.
❤️
…ol-eval-skia [CP Staging] Patch Skia to fix iOS chart crash and charts stuck loading (cherry picked from commit c9eb9d2) (cherry-picked to staging by mountiny)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.52-10 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.53-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.53-10 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Adds a patch to
@shopify/react-native-skia2.4.14 that removes a JSevalfrom its native JSI layer.JsiHostObject::getfalls back to a "dispose symbol" check whenever a property isn't found on a Skia host object, and that check callsjsi::eval(runtime, "Symbol.for('Symbol.dispose');"). Hermes without a runtime compiler rejects it, so the lookup throwsSyntaxError: Parsing source code unsupportedinstead of returningundefined. The patch obtains the symbol throughruntime.global()instead, which is byte-identical to the upstream fix in Shopify/react-native-skia#3855. It can be dropped once we bump Skia to >= 2.6.9. This reproduces only in builds whose Hermes lacks the compiler (Release builds).Fixed Issues
$ #98327
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-08-12.at.17.07.36.mov
iOS: mWeb Safari
MacOS: Chrome / Safari