fix: stop showing the canceled status on expense previews

[Krishna2323]

Explanation of Change

#98758 moved Canceled from the expense preview line up to the report level, but dropped the precedence it had before.

On production, Canceled was the last branch in the if/else chain. Cancelling a payment in a workspace with approvals puts the report back in APPROVED/APPROVED, so the Approved branch matched first and Canceled was never shown for that flow. Moving it to the report level made it show for the first time, and only in the Inbox, which is the inconsistency QA reported.

Fix: Keep the approved report-level placement, but don't show it when the badge is already Approved.

So:

• Approval flow → [Approved] 1 expense
• Other flows that don't end up approved, like optional approvals or Send Money → [Done] Canceled • 1 expense

Fixed Issues

$ #99091
PROPOSAL:

Tests

Canceled must NOT show

1. Workspace with approvals enabled: manual expense, submit, approve, mark as paid, go offline, cancel the payment.
2. Workspace chat preview shows 1 expense with the Approved badge — no Canceled • prefix.
3. Spend → Filters → Type: Chats — same, no Canceled. Both surfaces match.

Canceled MUST show (optimistically), at report level

4. Workspace with approvals disabled (optional approval): manual expense, mark as paid
5. Go offline Cancel the payment. The report preview header reads Canceled • 1 expense next to a Done badge.
6. Check Spend → Type: Chats shows the same thing as the inbox
7. Confirm Canceled never appears on the expense preview's supporting line in any of these — only at report level.

Regression checks

8. For an ordinary expense (not cancelled, not held), the supporting line reads Date • Category, with no stray • when the category is missing.
9. The expense report page still shows • Canceled on the expense itself (MoneyRequestView unchanged).
10. Pending and Pending match still appear where applicable.
11. Hold an expense: red RBR row reads This expense was put on hold, not repeated on the supporting line. With an extra violation: Category missing • This expense was put on hold.

• Verify that no errors appear in the JS console

Offline tests

• Same as tests

QA Steps

• Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-08-20.23-59-10.mp4

[melvin-bot]

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2375cfbc61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[trjExpensify]

I'm a bit confused by this. With approvals enabled, why wouldn't we show [Approved] Canceled * 1 expense like we do if approvals are disabled: [Done] Canceled * 1 expense`?

CC: @Expensify/design

[Krishna2323]

I'm a bit confused by this. With approvals enabled, why wouldn't we show [Approved] Canceled * 1 expense like we do if approvals are disabled: [Done] Canceled * 1 expense`?

That is indeed confusing and even with approvals disabled it disappears once API is successful, I'm just trying to match the prod behaviour in this PR. If we want to completely remove the "Canceled" text (for now), we can do that here and discuss the actual intended behaviour in a follow-up.

[situchan]

Both blockers were demoted so no need to hurry up merging this PR.
We can discuss the expected behavior here and update accordingly.

[Krishna2323]

@Expensify/design, bump on this when you get a chance: #99097 (review)

[dannymcclain]

I'm a bit confused by this. With approvals enabled, why wouldn't we show [Approved] Canceled * 1 expense like we do if approvals are disabled: [Done] Canceled * 1 expense`?

I'm not sure I'm totally following, and honestly didn't even know we displayed Canceled anywhere aside from the system message that records the action. But I think Tom's suggestion makes sense. Maybe a stupid question: why do we even need to show Canceled on the preview? Also, is it supposed to only show on the preview until you open the report?

[dubielzyk-expensify]

With approvals enabled, why wouldn't we show [Approved] Canceled * 1 expense like we do if approvals are disabled: [Done] Canceled * 1 expense`?

You got a screenshot of this Tom?

[dannymcclain]

@dubielzyk-expensify @trjExpensify I think this is what Tom is talking about? Please correct me if I'm wrong!

CleanShot.2026-08-27.at.08.10.46.mp4

[shawnborton]

Okay cool, that seems good to me? So no need to show it in the expense preview, just show it at the top report title line.