refactor: align expense preview card metadata line with mobile row styling, fix scanning and split layouts - #98758
Conversation
…yling, fix scanning and split layouts Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…tyle layer Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@situchan do you have ETA for a review here? thanks |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@shawnborton updated:
|
|
Thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safarihold.movscan1.movscan2.movsplit.mov |
|
Looks like both concerns were already design approved #98758 (comment) |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@shawnborton PR is up: #98976 |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.57-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site articles in No help site changes are required. This PR is a visual/layout-only refactor of the expense preview card. It does not add or change any user-facing feature, workflow, copy, or setting that the help site documents:
All strings used are existing translation keys ( Help site articles (e.g. Split Expenses, Create an Expense, SmartScan) describe how these features work and how to use them, none of which changed here — so no article edits are needed and no draft PR was created. If you believe a specific article should be updated to reflect any of these visual changes, let me know which one and I'll take another look. |
|
Deploy Blocker #99093 was identified to be related to this PR. |
|
Deploy Blocker #99091 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀
Bundle Size Analysis (Sentry): |










Explanation of Change
Fixed Issues
$ #96475
$ #98221
$ #98206
$ #98329
PROPOSAL:
Tests
Base layout — #96475
•when category is missing).[Approved] Canceled • 1 expense), not on the expense preview line.Scanning layout regression — #98221
Split avatar placement regression — #98206
Hold message placement regression — #98329
Date • Category.Date • Categoryline, and is not truncated.Category missing • This expense was put on hold.Review required • This expense was put on hold.Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-08-17.15-05-48.mp4