Atm File Rename to Standardized Form #4117
Merged
+1,221
−1,246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NOAA/global-workflow into maint/atm_rename
…NOAA/global-workflow into maint/atm_rename
DavidHuber-NOAA
removed
the
CI-Hercules-Failed
emcbot
added
CI-Hercules-Ready
emcbot
added
CI-Hercules-Passed
CoryMartin-NOAA
approved these changes
Oct 27, 2025
JessicaMeixner-NOAA
approved these changes
Oct 27, 2025
DavidNew-NOAA
approved these changes
Oct 27, 2025
WenMeng-NOAA
approved these changes
Oct 27, 2025
EricSinsky-NOAA
approved these changes
Oct 27, 2025
|
@WenMeng-NOAA I have opened #4186 to handle turning on |
| ecflow_client --event release_fcst | ||
| fi | ||
| echo "${rCDUMP} ${PDY}${cyc} atminc done at $(date)" > "${COMOUT_ATMOS_ANALYSIS}/${APREFIX}loginc.txt" | ||
| echo "${rCDUMP} ${PDY}${cyc} atminc done at $(date)" > "${COMOUT_ATMOS_ANALYSIS}/${APREFIX}analysis.done.txt" |
There was a problem hiding this comment.
This should have been increment.done.txt.
| fi | ||
|
|
||
| echo "${rCDUMP} ${PDY}${cyc} atmanl and sfcanl done at $(date)" > "${COMOUT_ATMOS_ANALYSIS}/${APREFIX}loganl.txt" | ||
| echo "${rCDUMP} ${PDY}${cyc} atmanl and sfcanl done at $(date)" > "${COMOUT_ATMOS_ANALYSIS}/${APREFIX}done.txt" |
There was a problem hiding this comment.
This should have been analysis.done.txt
| # Write analysis log file | ||
| formatted_date = datetime.now().strftime("%a %b %d %H:%M:%S %Z%Y") | ||
| log_file = os.path.join(self.task_config.COMOUT_ATMOS_ANALYSIS, f"{self.task_config.RUN}.t{self.task_config.cyc}z.loganl.txt") | ||
| log_file = os.path.join(self.task_config.COMOUT_ATMOS_ANALYSIS, f"{self.task_config.RUN}.t{self.task_config.cyc}z.done.txt") |
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}cnvstat.tar" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}abias_int.txt" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}analysis.dtf.a006.nc" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}analysis.done.txt" |
There was a problem hiding this comment.
increment.done.txt
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}dtfanl.nc" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}loginc.txt" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}analysis.dtf.a006.nc" | ||
| - "{{ COMIN_ATMOS_ANALYSIS | relpath(ROTDIR) }}/{{ head }}analysis.done.txt" |
There was a problem hiding this comment.
increment.done.txt
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All intermediate and final atm output files are standardized according to the proposed format in the spreadsheet L80-139.
Resolves Rename atm files to standardized form #3271
Follow-on issues for TODOs:
Type of change
Change characteristics
How has this been tested?
Checklist