Allow temporal partition mappers to accept already-normalized keys - #70781
bujjibabukatta wants to merge 1 commit into
Conversation
|
Hello @bujjibabukatta - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 16 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Temporal partition mappers (
StartOfHourMapper,StartOfDayMapper,StartOfWeekMapper,StartOfMonthMapper,StartOfQuarterMapper,StartOfYearMapper) raisedValueErrorwhen an upstream key didn't matchinput_format, even if it was already at (or coarser than) the mapper's own granularity — e.g.StartOfDayMapper().to_downstream("2026-07-30")failed because the defaultinput_formatexpects a full timestamp.to_downstreamnow falls back to parsing the key viaoutput_format(through the existingdecode_downstream) wheninput_formatdoesn't match, instead of raising immediately. This requires noinput_formatoverride for day-granularity (or any-granularity) upstream keys, and makes a mapper's own downstream output chainable back through another instance of itself. Keys matching neither format still raise a clearValueErrornaming both formats tried.Closes #70762
AI disclosure
Used Claude (Anthropic) to help analyze the issue and draft the fix. Reviewed and tested by me.
Important
🛠️ Maintainer triage note for @bujjibabukatta · by
@potiuk· 2026-08-13 12:55 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
Full list of what we check: Pull Request quality criteria.
The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
Automated triage — may be imperfect; a maintainer takes the next look.