Skip to content

Allow temporal partition mappers to accept already-normalized keys - #70781

Closed
bujjibabukatta wants to merge 1 commit into
apache:mainfrom
bujjibabukatta:fix/#70762
Closed

bujjibabukatta wants to merge 1 commit into
apache:mainfrom
bujjibabukatta:fix/#70762

Conversation

@bujjibabukatta

@bujjibabukatta bujjibabukatta commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Temporal partition mappers (StartOfHourMapper, StartOfDayMapper, StartOfWeekMapper, StartOfMonthMapper, StartOfQuarterMapper, StartOfYearMapper) raised ValueError when an upstream key didn't match input_format, even if it was already at (or coarser than) the mapper's own granularity — e.g. StartOfDayMapper().to_downstream("2026-07-30") failed because the default input_format expects a full timestamp.

to_downstream now falls back to parsing the key via output_format (through the existing decode_downstream) when input_format doesn't match, instead of raising immediately. This requires no input_format override for day-granularity (or any-granularity) upstream keys, and makes a mapper's own downstream output chainable back through another instance of itself. Keys matching neither format still raise a clear ValueError naming both formats tried.

Closes #70762

AI disclosure

Used Claude (Anthropic) to help analyze the issue and draft the fix. Reviewed and tested by me.


Important

🛠️ Maintainer triage note for @bujjibabukatta · by @potiuk · 2026-08-13 12:55 UTC

Helpful heads-up from the maintainers — please address before this PR can be reviewed:

  • ❌ Other failing CI checks. See docs.
  • ❌ Pre-commit / static checks. See docs.
  • ❌ Unit tests. See docs.

Full list of what we check: Pull Request quality criteria.

The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.

Automated triage — may be imperfect; a maintainer takes the next look.

@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @bujjibabukatta - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 16 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StartOfDayMapper does not work on assets that return a Date

2 participants