Skip to content

Skip file-based dag processor logs when dag_processor_log_target=stdout - #71052

Closed
bujjibabukatta wants to merge 2 commits into
apache:mainfrom
bujjibabukatta:fix/#70968
Closed

bujjibabukatta wants to merge 2 commits into
apache:mainfrom
bujjibabukatta:fix/#70968

Conversation

@bujjibabukatta

Copy link
Copy Markdown
Contributor

Summary
Setting [logging] dag_processor_log_target = stdout was documented to disable
file-based dag processor logs, but the logs/dag_processor directory kept
growing regardless.

Root cause
_get_logger_for_dag_file() in manager.py unconditionally created and opened
a log file for every dag file processed, regardless of dag_processor_log_target.
The config only affected the subprocess's own stdout capture, not this
separate file-based logger.

Fix
When dag_processor_log_target is "stdout", skip file creation entirely and
use structlog.PrintLogger() instead. Updated processor.py's logger_filehandle
to be Optional and guarded its close() call accordingly, since no file
handle exists in that mode.

closes: #70968

Was generative AI tooling used ?

  • Yes - Claude

Generated-by: Claude following the guidelines

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Aug 13, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @bujjibabukatta - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 16 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dag-processor closed because of open PR limit Closed as a one-time step of introducing the open pull request limit ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot deactivate File-based logs for at processor

2 participants