Skip file-based dag processor logs when dag_processor_log_target=stdout - #71052
bujjibabukatta wants to merge 2 commits into
Conversation
6e4e22c to
c51e01d
Compare
c51e01d to
10b0eee
Compare
bb475cf to
ddc5b97
Compare
|
Hello @bujjibabukatta - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 16 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Summary
Setting [logging] dag_processor_log_target = stdout was documented to disable
file-based dag processor logs, but the logs/dag_processor directory kept
growing regardless.
Root cause
_get_logger_for_dag_file() in manager.py unconditionally created and opened
a log file for every dag file processed, regardless of dag_processor_log_target.
The config only affected the subprocess's own stdout capture, not this
separate file-based logger.
Fix
When dag_processor_log_target is "stdout", skip file creation entirely and
use structlog.PrintLogger() instead. Updated processor.py's logger_filehandle
to be Optional and guarded its close() call accordingly, since no file
handle exists in that mode.
closes: #70968
Was generative AI tooling used ?
Generated-by: Claude following the guidelines