Skip to content

Surface hasMappedDependants on ts-sdk TaskContext - #71191

Closed
bujjibabukatta wants to merge 4 commits into
apache:mainfrom
bujjibabukatta:fix/#71063
Closed

bujjibabukatta wants to merge 4 commits into
apache:mainfrom
bujjibabukatta:fix/#71063

Conversation

@bujjibabukatta

@bujjibabukatta bujjibabukatta commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Adds TaskContext.hasMappedDependants to the TypeScript SDK, mirroring
the should_retry field pattern already used for TIRunContext →
TaskContext mapping.

When true, returning an array from a task handler causes the
supervisor to record mapped_length on the return-value XCom
automatically, letting the scheduler expand downstream mapped
dependants — matching behavior already available to Python task
handlers.

Changes:

  • ts-sdk/src/sdk/task.ts — add readonly hasMappedDependants: boolean
    to the public TaskContext interface
  • ts-sdk/src/coordinator/runtime.ts — wire ti_context.has_mapped_dependants
    into buildContext(), defaulting to false when the server omits it
  • ts-sdk/tests/coordinator/integration.test.ts — cover both the
    true and default-false cases end-to-end through the coordinator
  • ts-sdk/tests/coordinator/client.test.ts, ts-sdk/tests/public-api.test.ts —
    update existing TaskContext fixtures/type assertions for the new
    required field

Depends on has_mapped_dependants existing on TIRunContext
(#70571) — rebased onto that once merged, schema.json /
supervisor.ts regeneration is a no-op beyond the one field.

closes: #71063

Was generative AI tooling used to co-author this PR?
  • Yes (Claude)
  • Used for PR description and test cases

Important

🛠️ Maintainer triage note for @bujjibabukatta · by @potiuk · 2026-08-13 12:55 UTC

Helpful heads-up from the maintainers — please address before this PR can be reviewed:

  • ❌ Merge conflicts. See docs.
  • ❌ Pre-commit / static checks. See docs.

Full list of what we check: Pull Request quality criteria.

The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.

Automated triage — may be imperfect; a maintainer takes the next look.

@potiuk
potiuk marked this pull request as draft August 13, 2026 13:01
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @bujjibabukatta - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 16 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk area:ts-sdk closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Record mapped_length for TypeScript SDK tasks with mapped dependants

2 participants