Conversation
3469109 to
f5b4daa
Compare
The core suite uses CeleryExecutor as its stand-in for "a distributed executor" and the [celery] section as its stand-in for "config a provider contributed", so a scoped `uv sync --project airflow-core` environment cannot run it unless the celery provider is installed. One of those uses is a conftest import, which takes the whole unit/cli directory down with it. The celery CLI integration test also sat under airflow-core, where the celery integration is never started, so it has never actually run — long enough for the subprocess target it asserts on to be renamed underneath it.
afb8154 to
dc2aadf
Compare
|
Hello @rjgoyln - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Summary
unit/cli/conftest.pyimports the Celery executor at module level. As a result, when the provider is uninstalled, nothing underunit/clican be collected. This was the first Celery blocker to running the core suite in a scopeduv sync --project airflow-core.The remaining Celery dependencies are replaced with stand-ins:
CeleryExecutoris used wherever a test needs a non-local executor.[celery]is used wherever a test needs an option contributed by a provider.Where core already has an equivalent, the Celery-specific dependency is replaced rather than skipped. This keeps the test running in a Celery-free environment.
The provider-config toggle test is moved to
[standard] venv_install_method. Its subject is the context manager itself. The one behavior that Celery provided butstandarddoes not — metadata taking precedence overprovider_config_fallback_defaults.cfg— is covered separately bytest_provider_metadata_overrides_cfg_fallback.TestProviderConfigPriorityrows are now marked by the section that owns each option, rather than by which cases happen to fail. Both[celery]and[celery_kubernetes_executor]are defined byproviders/celery/provider.yaml. Several of their options also resolve to the same values through the core cfg fallback, so those cases could pass without actually proving the provider-specific behavior.In
test_executor_loader.py, the module-levelimportorskippreviously skipped the entire file instead of only the four cases that require Celery. The Amazonimportorskip, thecncf.kubernetesimport inunit/cli/conftest.py, and the dev-group entry are left unchanged because they are still needed by the remaining test slices.The Celery CLI integration test is moved under the provider.
testable-core-integrationsonly covers Kerberos, OpenTelemetry, and Redis;INTEGRATION_CELERYis never enabled underairflow-core, so this test has effectively never run there.Running it under the provider exposed a stale
_bundle_cleanup_mainexpectation, which had been renamed in #62655. Updating that expectation is the only assertion changed by this PR.Tests
Without
apache-airflow-providers-celeryinstalled:airflow-core/tests/unitandtests/integrationnow collect cleanly, whereasunit/clipreviously failed during collection.The touched tests skip instead of failing:
test_configuration.pyunit/executorstest_cli_parser.pyWith the provider installed, nothing changes.
Two existing failures are intentionally left untouched in the scoped venv:
test_sensitive_valuestest_providers_manager.py::test_cliBoth assert against the full provider set and already miss
keycloakandedge3in this environment, so they are unrelated to this PR.Finally,
markers.pyandunit/cli/conftest.pyoverlap with #71868: both contain the sameskip_if_not_installedimplementation. Whichever lands second will need to deduplicate that code.related: #71641
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines