Conversation
Instantiating a trigger in the runner only contained TypeError. Any other exception raised by a trigger's __init__, or while decrypting and decoding its kwargs, escaped the runner loop, killed the TriggerRunner subprocess and took the whole triggerer down. Once restarted, the triggerer picked the same trigger up again and crashed in a loop until the task was cleared. Narrowing the guard to TypeError in apache#31999 was a readability choice rather than a design decision, and the class-loading step a few lines above already fails only the offending trigger. Do the same for instantiation, catching Exception rather than BaseException so cancellation and shutdown still reach the runner loop, and one bad trigger never stops the others.
|
Hello @rjgoyln - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Summary
A trigger whose constructor raises anything but
TypeErrorwhile the triggerer re-creates it stops the whole triggerer: the exception escapescreate_triggers, the runner subprocess exits, and the supervisor exits with it. After a restart the same trigger is picked up again, so the triggerer crash-loops until the task is cleared. Failures while decrypting or decoding the stored kwargs, or while rebuilding the runtime task instance and template context for a task started from a trigger, take the same path.A bad classpath a few lines above already fails only that trigger; the constructor guard now does the same, stopping at
Exceptionso cancellation and shutdown still reach the runner loop. TheTypeError-only guard from #31999 came from a readability suggestion in review, not from a reason to let other exceptions through.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5.1) following the guidelines