Conversation
On Airflow 3.3+ the triggerer invokes a trigger's on_kill() only when the trigger lets asyncio.CancelledError propagate out of run(). Both Dataproc submit triggers caught it and returned instead, so killing a deferred task left the Dataproc job running and the triggerer additionally reported the trigger as having exited without sending an event.
f48e74f to
781832b
Compare
|
Hi @rjgoyln, Thank you for your change. From my side, it seems a good change. However we want to see the system tests run results before merging a change. Did you run the system tests? Can you share the results of the system tests? |
|
Hello @rjgoyln - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Summary
The triggerer calls a trigger's
on_kill()only whenasyncio.CancelledErrorpropagates out ofrun(). Both Dataproc submit triggers catch it and return, so on Airflow 3.3+ killing or clearing a deferred task leaves:Trigger exited without sending an event. Dependent tasks will be failed.in the triggerer logRe-raising restores the cleanup path that migrating these triggers to
on_kill()was meant to keep. The pre-3.3 branch handles cancellation inline and is left alone, so the regression tests are scoped to 3.3+.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines