Remove the dead cloudant_fake module - #72847
Closed
jabrailkhalil wants to merge 1 commit into
Closed
jabrailkhalil wants to merge 1 commit into
jabrailkhalil wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
jabrailkhalil
force-pushed
the
remove-dead-cloudant-fake
branch
from
September 10, 2026 12:28
5c182e2 to
1497132
Compare
cloudant_fake.py provided CloudantV1 and CouchDbSessionAuthenticator stand-ins for the conditional import fallback used while ibmcloudant was excluded on Python 3.9. PR apache#52072 dropped Python 3.9 support and removed the version guard, leaving the hook importing both classes directly from ibmcloudant. Delete the unused module and its OVERLOOKED_TESTS entry. Rebase the cleanup onto current main without changing unrelated provider entries. Fixes apache#72269 Signed-off-by: jabrailkhalil <jabrailkhalil@gmail.com>
jabrailkhalil
force-pushed
the
remove-dead-cloudant-fake
branch
from
September 10, 2026 17:45
1497132 to
9aaab8a
Compare
Author
|
The CI workflows for the current head |
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
providers/cloudant/src/airflow/providers/cloudant/cloudant_fake.pyis dead code: it defined two no-op stand-ins (CloudantV1,CouchDbSessionAuthenticator) for the conditional import fallback that was needed whileibmcloudantwas excluded on Python 3.9. PR #52072 dropped Python 3.9 support, removed the version guard and theexcluded-python-versionsblock, and the hook now imports both classes directly fromibmcloudant. The stub module was left behind.A repository-wide search finds no import of
airflow.providers.cloudant.cloudant_fakein any source, test, or configuration file; its only remaining reference was its ownOVERLOOKED_TESTSentry.Changes
providers/cloudant/src/airflow/providers/cloudant/cloudant_fake.py.providers/cloudant/tests/unit/cloudant/test_cloudant_fake.pyentry fromOVERLOOKED_TESTSinairflow-core/tests/unit/always/test_project_structure.py.Verification
grep -r cloudant_fakeacross the repository: only the allowlist entry existed (now removed).pytest airflow-core/tests/unit/always/test_project_structure.py -k TestProjectStructure --confcutdir=...: 3 passed, includingtest_providers_modules_should_have_tests(the allowlist check).test_project_structure.pyrun has 1 pre-existing failure unrelated to this change:TestDockerProviderProjectStructure::test_missing_examplesraisesUnicodeDecodeErroron Windows (python reads a provider file with the defaultcp1251codec; no encoding is specified in the test). It also fails on a clean checkout on this platform.No newsfragment is needed: no user-visible behavior changes (internal dead module removed, test-allowlist cleanup).
Fixes #72269