Drop support for Python 3.9 - #52072
Conversation
|
👀 |
3.9 is also hard-coded in a few github action workflows where it had to be added by hand (because you cannot run breeze before you install breeze to check which version of python is supported :D ) . Classic chicken-egg |
f1a79b8 to
f4590e6
Compare
389da96 to
54587d1
Compare
gopidesupavan
left a comment
There was a problem hiding this comment.
Thanks Elad.
LGTM, mostly type changes ;)
|
Looks good (minus the current failures of course so indeed we should merge it quickly) - reviewed with There will be cherry-pick issues, but it's inevitable and we should just let peopel know to pay attention to the kinds of changes that they are expected to "revert" when cherry-picking. |
amoghrajesh
left a comment
There was a problem hiding this comment.
Looks fine to me. It mainly looks like type checking has had an impact, rest is pretty ok +1
|
👀 👀 .... and I might be able to complete 3.13 as a follow up.... |
|
Wooohoooo ! |
|
Cool :) |
|
Cool! |
|
Awesome! |
Discussion: https://lists.apache.org/thread/0th63mgfc51jy7bch032hskbgoyzyhs2
Lazy consensus: https://lists.apache.org/thread/5b3w2ofb2hjqcszkd21sg815rc0yxovt