Remove the dead cloudant_fake module - #72457
Merged
Merged
Conversation
cloudant_fake.py provided no-op CloudantV1 and CouchDbSessionAuthenticator stubs for the Python 3.9 fallback import in the cloudant hook. apache#52072 dropped Python 3.9 support and removed the version guard, so the hook imports both names directly from ibmcloudant and nothing references the stub any more -- its only remaining mention in the repository was its own OVERLOOKED_TESTS entry, which this also drops. Closes: apache#72269
Contributor
Author
|
Same situation as #72456: the workflow runs here have been in Could a committer approve the runs when convenient? This removes the dead |
shahar1
approved these changes
Sep 14, 2026
This was referenced Sep 14, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudant_fake.py is a pair of no-op stubs for CloudantV1 and CouchDbSessionAuthenticator. They were there for the Python 3.9 import fallback, back when the hook couldn't assume ibmcloudant was installed.
That situation is gone. #52072 dropped 3.9 support and took the sys.version_info guard with it, and the hook now imports from ibmcloudant directly.
I grepped the whole repo for anything touching the stub and came up empty, other than its own line in OVERLOOKED_TESTS. So this deletes the file and drops the entry.
Worth saying out loud: the issue author asked for a second opinion from someone with context on the original optional-import setup before the file goes away. This PR is that deletion, so take it as the invitation. If anyone knows a reason to keep the stub around, say so and I'll close this.
Closes: #72269
Test Plan
cloudant_fakereturns only theOVERLOOKED_TESTSentry that this PR removes.providers/cloudant/src/airflow/providers/cloudant/hooks/cloudant.pyimportsCloudantV1andCouchDbSessionAuthenticatordirectly fromibmcloudant, with nosys.version_infoguard left.breeze run mypy providers/cloudantlocally. Nothing imports the deleted module, so it cannot take part in type checking anything else, but the CI mypy run is the real confirmation here.Was generative AI tooling used to co-author this PR?
Change drafted with Claude Code (Opus 5); reviewed and verified by @vitorantoniazzi