Remove the dead cloudant_fake module - #72880
Closed
MoonPointer-Byte wants to merge 1 commit into
Closed
MoonPointer-Byte wants to merge 1 commit into
MoonPointer-Byte wants to merge 1 commit into
Conversation
The cloudant_fake stub was only used for Python 3.9 mypy fallbacks. Since Python 3.9 support was dropped, the hook imports directly from ibmcloudant and the module is unused. Fixes apache#72269
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudant_fake.pystub module from the Cloudant providerOVERLOOKED_TESTSallowlist intest_project_structure.pyThe module was a mypy fallback for Python 3.9 when
ibmcloudantwas excluded. Python 3.9 support was dropped in #52072 and the hook now importsCloudantV1andCouchDbSessionAuthenticatordirectly fromibmcloudant. No remaining code referencescloudant_fake.Fixes #72269
Test plan
cloudant_fakein the repositorybreeze testing providers-tests providers/cloudant/tests/unit/cloudantbreeze run mypy providers/cloudant/src/airflow/providers/cloudant