Skip to content

Remove the dead cloudant_fake module - #72880

Closed
MoonPointer-Byte wants to merge 1 commit into
apache:mainfrom
MoonPointer-Byte:fix/remove-cloudant-fake
Closed

MoonPointer-Byte wants to merge 1 commit into
apache:mainfrom
MoonPointer-Byte:fix/remove-cloudant-fake

Conversation

@MoonPointer-Byte

@MoonPointer-Byte MoonPointer-Byte commented Sep 10, 2026 •

Copy link
Copy Markdown

Summary

  • Delete the unused cloudant_fake.py stub module from the Cloudant provider
  • Remove its entry from the OVERLOOKED_TESTS allowlist in test_project_structure.py

The module was a mypy fallback for Python 3.9 when ibmcloudant was excluded. Python 3.9 support was dropped in #52072 and the hook now imports CloudantV1 and CouchDbSessionAuthenticator directly from ibmcloudant. No remaining code references cloudant_fake.

Fixes #72269

Test plan

  • Verified no remaining references to cloudant_fake in the repository
  • breeze testing providers-tests providers/cloudant/tests/unit/cloudant
  • breeze run mypy providers/cloudant/src/airflow/providers/cloudant

The cloudant_fake stub was only used for Python 3.9 mypy fallbacks.
Since Python 3.9 support was dropped, the hook imports directly from
ibmcloudant and the module is unused.

Fixes apache#72269
@boring-cyborg

boring-cyborg Bot commented Sep 10, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@shahar1

shahar1 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!
As #72457 preceeded this PR and solves this issue the exact same way - I'll merge the former.
Feel free to solve other open issues.

@shahar1 shahar1 closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the dead cloudant_fake module, or add its missing tests

2 participants