Remove dead cloudant_fake stub module - #73137
Closed
bhargavikvmpl-2001 wants to merge 1 commit into
Closed
bhargavikvmpl-2001 wants to merge 1 commit into
bhargavikvmpl-2001 wants to merge 1 commit into
Conversation
cloudant_fake.py defined two no-op stand-ins for CloudantV1 and CouchDbSessionAuthenticator, used as a Python 3.9 mypy fallback while ibmcloudant was excluded on that version. apache#52072 dropped Python 3.9 support and the hook now imports both classes directly from ibmcloudant, leaving the stub unreachable. A repo-wide search confirms no remaining references to cloudant_fake outside its own entry in the OVERLOOKED_TESTS allowlist, which is removed here along with the file. Closes apache#72269 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudant_fake.pydefined two no-op stand-ins (CloudantV1,CouchDbSessionAuthenticator) used as a Python 3.9 mypy fallback whileibmcloudantwas excluded on that version. #52072 dropped Python 3.9 support and the hook now imports both classes directly fromibmcloudant, leaving the stub unreachable.A repo-wide search confirms no remaining references to
cloudant_fakeoutside its own entry in theOVERLOOKED_TESTSallowlist intest_project_structure.py.providers/cloudant/src/airflow/providers/cloudant/cloudant_fake.pyOVERLOOKED_TESTSentry inairflow-core/tests/unit/always/test_project_structure.pyCloses #72269
Test plan
Docker/breeze wasn't available in my environment, so I verified both of the issue's required checks by other means against the actual repo:
test_providers_modules_should_have_tests— replicated the test's exact algorithm as a standalone script against the live filesystem:missing_tests_filesandadded_test_filesboth come back empty.mypyonproviders/cloudant/src/airflow/providers/cloudant— installed mypy +ibmcloudantin an isolated venv and ran mypy scoped to the 5 cloudant source files:Success: no issues found in 5 source files.cloudant_fakehas zero remaining references anywhere in the repo.🤖 Generated with Claude Code