Skip to content

Remove dead cloudant_fake stub module - #73137

Closed
bhargavikvmpl-2001 wants to merge 1 commit into
apache:mainfrom
bhargavikvmpl-2001:remove-cloudant-fake-stub
Closed

bhargavikvmpl-2001 wants to merge 1 commit into
apache:mainfrom
bhargavikvmpl-2001:remove-cloudant-fake-stub

Conversation

@bhargavikvmpl-2001

Copy link
Copy Markdown

Summary

cloudant_fake.py defined two no-op stand-ins (CloudantV1, CouchDbSessionAuthenticator) used as a Python 3.9 mypy fallback while ibmcloudant was excluded on that version. #52072 dropped Python 3.9 support and the hook now imports both classes directly from ibmcloudant, leaving the stub unreachable.

A repo-wide search confirms no remaining references to cloudant_fake outside its own entry in the OVERLOOKED_TESTS allowlist in test_project_structure.py.

  • Deleted providers/cloudant/src/airflow/providers/cloudant/cloudant_fake.py
  • Removed its OVERLOOKED_TESTS entry in airflow-core/tests/unit/always/test_project_structure.py

Closes #72269

Test plan

Docker/breeze wasn't available in my environment, so I verified both of the issue's required checks by other means against the actual repo:

  • test_providers_modules_should_have_tests — replicated the test's exact algorithm as a standalone script against the live filesystem: missing_tests_files and added_test_files both come back empty.
  • mypy on providers/cloudant/src/airflow/providers/cloudant — installed mypy + ibmcloudant in an isolated venv and ran mypy scoped to the 5 cloudant source files: Success: no issues found in 5 source files.
  • Confirmed via GitHub code search and a fresh local grep that cloudant_fake has zero remaining references anywhere in the repo.

🤖 Generated with Claude Code

cloudant_fake.py defined two no-op stand-ins for CloudantV1 and
CouchDbSessionAuthenticator, used as a Python 3.9 mypy fallback while
ibmcloudant was excluded on that version. apache#52072 dropped Python 3.9
support and the hook now imports both classes directly from
ibmcloudant, leaving the stub unreachable. A repo-wide search confirms
no remaining references to cloudant_fake outside its own entry in the
OVERLOOKED_TESTS allowlist, which is removed here along with the file.

Closes apache#72269

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@boring-cyborg

boring-cyborg Bot commented Sep 14, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@shahar1

shahar1 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!
As #72457 preceeded this PR and solves this issue the exact same way - I'll merge the former.
Feel free to solve other open issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the dead cloudant_fake module, or add its missing tests

2 participants