chore: Trust domain setting adjustments #7
Conversation
Summary of ChangesHello @jsnctl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how the trust domain setting is handled within the server configuration. The change centralizes the assignment of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors how the trust domain is configured by moving its assignment from the HCL parsing logic to the main Configure method. This is a positive change for separation of concerns. I have provided one suggestion to further improve this refactoring by also relocating the related validation logic, which would enhance modularity.
| return nil, err | ||
| } | ||
| p.config = cfg | ||
| p.config.trustDomain = req.CoreConfiguration.GetTrustDomain() |
There was a problem hiding this comment.
This is a good refactoring to separate concerns. To complete it, consider also moving the validation for the trust domain from buildConfig into this Configure method. Currently, buildConfig still validates coreConfig.TrustDomain, even though it no longer uses it for assignment. Moving the validation here would make buildConfig fully independent of the core configuration regarding the trust domain, improving modularity.
| if coreConfig == nil { | ||
| return nil, status.Errorf(codes.InvalidArgument, "global configuration is required") | ||
| } | ||
| if coreConfig.TrustDomain == "" { | ||
| return nil, status.Errorf(codes.InvalidArgument, "trust_domain is required") | ||
| } |
There was a problem hiding this comment.
Fair point my gemini re this.
Slight adjustment to trust domain setting for use with Cofide SPIRE Connect Data Store