Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Azure writes #136

Merged
merged 22 commits into from
Apr 4, 2023
Merged

Enable Azure writes #136

merged 22 commits into from
Apr 4, 2023

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Mar 26, 2023

This branch is a work in progress with @mightyshazam and is not yet ready for merging into main

@rtyler rtyler self-assigned this Mar 26, 2023
This was referenced Mar 26, 2023
@rtyler rtyler marked this pull request as ready for review April 3, 2023 19:35
@rtyler
Copy link
Member Author

rtyler commented Apr 4, 2023

Frustratingly I cannot reproduce these test failures locally on Ubuntu 😠

@mightyshazam
Copy link
Collaborator

Frustratingly I cannot reproduce these test failures locally on Ubuntu 😠

I had these tests working before I created the new branch. I must have accidentally added the ignore attributes back. I believe the ultimate fix came down to increasing the duration of the calls to std::thread::sleep. It's harder to reproduce on Ubuntu because docker isn't running in a VM.

@rtyler
Copy link
Member Author

rtyler commented Apr 4, 2023

@mightyshazam thanks for the suggestions, I've gone ahead and re-ignored the tests for now. I have also force pushed the branch after rebasing some commits together. If this goes ✔️ then I will merge!

@rtyler rtyler requested review from xianwill and mosyp April 4, 2023 15:24
@rtyler rtyler enabled auto-merge (squash) April 4, 2023 15:25
@rtyler rtyler disabled auto-merge April 4, 2023 17:07
@rtyler rtyler merged commit 5b0b546 into main Apr 4, 2023
@rtyler rtyler deleted the azure-writes branch April 4, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants