Verilog: distinguish packed and unpacked arrays #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
verilog-array-types
branch
from
9f0614b to
1379aa5
Compare
kroening
force-pushed
the
verilog-array-types
branch
from
07af57a to
cfde596
Compare
tautschnig
approved these changes
Mar 18, 2024
tautschnig
reviewed
Mar 18, 2024
| else | ||
| array_subtype = array_type(src_subtype, element_type); | ||
|
|
||
| const exprt final_size_expr = from_integer(size, natural_typet()); |
There was a problem hiding this comment.
In #407 the type was changed to integer_typet. (And this is now a git conflict that requires resolving.)
kroening
force-pushed
the
verilog-array-types
branch
from
cfde596 to
bd76093
Compare
This adds two new IDs to distinguish packed and unpacked arrays in the Verilog parse tree.
This removes the net_name rule, and makes the assignment in the net_decl_assignment rule optional, to match SystemVerilog 1800-2017.
This moves the verilog_typecheckt::array_type method to verilog_typecheck_exprt, together with the other type conversion methods.
kroening
force-pushed
the
verilog-array-types
branch
from
bd76093 to
0844c0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new IDs to distinguish packed and unpacked arrays in the Verilog parse tree.