test(synapse): use neutral fixture hostname in mutation-exec tests - #326
test(synapse): use neutral fixture hostname in mutation-exec tests#326jmagar wants to merge 2 commits into
Conversation
|
Reviewed the outstanding finding on this PR: the note that other fleet/infra test suites ( That's correctly flagged as pre-existing and out of scope here — this PR only touches the four synapse mutation-exec test files it set out to fix. Left those other files untouched to keep this change path-limited, and opened a follow-up task to rename those fixture literals to neutral placeholders (e.g. No other findings on this PR; CI is green and mergeable. |
|
Reviewed the automated findings for this PR. The only item raised is informational and explicitly out of scope: it notes that other fixture test suites ( No changes were needed in this PR itself:
Flagged the fleet/infra fixture cleanup as a follow-up task so it isn't lost. |
…333) Replace the real username 'jmagar' with the neutral placeholder 'devuser' in fleet and infra test fixtures, including the /home/jmagar/.ssh/* paths in the OpenSSH connector and endpoint tests and the user column of the ps-output fixtures. Follows the precedent set by #326 (devhost fixture hostname) and completes the hostname scrub in #325, which neutralized host names but left the username in place. Test fixture literals only; no behavior change.
PR #317 merged before its review finding on a literal internal hostname in the new host/container exec test fixtures was addressed. Replace it with a neutral placeholder now that it landed on main.
d676f17 to
60989bb
Compare
* chore: scrub internal network identifiers Replace internal IP addresses, the internal tailnet domain, and host aliases in tracked files with neutral documentation placeholders (192.0.2.0/24, 198.51.100.0/24, example.ts.net, *.example.internal, role-based host aliases). * fix: address review findings on identifier scrub - Run cargo fmt on topology_tests.rs (line exceeded wrap width after the devhost rename) - Rename old_dookie/new_dookie -> old_devhost/new_devhost in cache_tests.rs so local variable names don't retain the raw internal hostname substring - Rename squirts_pos -> edgehost_pos in formatters_tests.rs for the same reason - Re-pad the doc-comment example markdown table in formatters/host.rs after the squirts->edgehost substitution widened a column * test(fleet,infra): use neutral fixture username in operations tests (#333) Replace the real username 'jmagar' with the neutral placeholder 'devuser' in fleet and infra test fixtures, including the /home/jmagar/.ssh/* paths in the OpenSSH connector and endpoint tests and the user column of the ps-output fixtures. Follows the precedent set by #326 (devhost fixture hostname) and completes the hostname scrub in #325, which neutralized host names but left the username in place. Test fixture literals only; no behavior change.
Summary
Test plan
cargo test -p synapse-application mutation_exec(10 passed)cargo test -p synapse-application(full crate suite, all passed)cargo test -p soma-infra --features process-drivertargeted at the touchedprocess_host_exectests (3 passed)