RFC with enhancements to MultimodalQnA #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]> Signed-off-by: Melanie Buehler <[email protected]>
…d some gateway info. Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
… input Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
…agram for Gaudi using tgi Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Language edits and UI alternative
Signed-off-by: Dina Suehiro Jones <[email protected]>
* Adds pdf processing details Signed-off-by: Melanie Buehler <[email protected]> * Edit title header Signed-off-by: Melanie Buehler <[email protected]> --------- Signed-off-by: Melanie Buehler <[email protected]>
* Update compatibility section Signed-off-by: Dina Suehiro Jones <[email protected]> * Wording Signed-off-by: Dina Suehiro Jones <[email protected]> --------- Signed-off-by: Dina Suehiro Jones <[email protected]>
* added other enhancements Signed-off-by: okhleif-IL <[email protected]> * changed wording * can --> will Signed-off-by: okhleif-IL <[email protected]> * addressed rev comments Signed-off-by: okhleif-IL <[email protected]> --------- Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
dmsuehir
requested review from
chensuyue,
ftian1,
mkbhanda,
preethivenkatesh,
chickenrae and
tomlenth
as code owners
|
It looks like the relative path hyperlink check is failing because it's assume that the name of my fork is So, the URL being checked in the test is incorrect. It's looking for https://github.com/dmsuehir/docs/tree/dina/mm-rfc/community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md#data-ingestion-and-prep (which doesn't exist), but the correct link works: https://github.com/dmsuehir/opea-project-docs/blob/dina/mm-rfc/community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md#data-ingestion-and-prep I manually checked the links that are being called out as failing to verify that they work with the corrected URL. |
ashahba
reviewed
Oct 16, 2024
community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md
Show resolved
Hide resolved
ftian1
approved these changes
Oct 17, 2024
This was referenced Oct 21, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an RFC which proposes enhancements to the MultimodalQnA megaservice. MultimodalQnA currently supports videos (with or without transcriptions) and text queries. The RFC proposes adding support for images (with or without text) and speech audio files for both queries and for data prep/ingestion.
FYI @tileintel @MSCetin37 @mhbuehler @okhleif-IL @ashahba