8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset #3720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-UTF8 charset 8355975: ZipFile uses incorrect Charset if another instance for the same ZIP file was constructed with a different Charset Co-authored-by: Eirik Bjørsnøs <[email protected]> Reviewed-by: eirbjo, lancea, redestad, alanb
|
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issues from the original commit. |
openjdk
bot
added
backport
Webrevs
|
phohensee
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Almost clean backport from the 21u backport openjdk/jdk21u-dev#1949. Lgtm.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multithreaded handling of ZIP files can throw an exception.
This backport is far from clean. The last commit resolves the conflicts.
The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is a backward compatibility concern I have not backported it.
(jdk25 already contains it), jdk21, this jdk17.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3720/head:pull/3720$ git checkout pull/3720Update a local copy of the PR:
$ git checkout pull/3720$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3720/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3720View PR using the GUI difftool:
$ git pr show -t 3720Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3720.diff
Using Webrev
Link to Webrev Comment