Skip to content
This repository was archived by the owner on Jul 15, 2025. It is now read-only.

8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Jul 8, 2025

Multithreaded handling of ZIP files can throw an exception.

This is a clean backport.

This jdk24, jdk21, jdk17.


Progress

  • JDK-8347712 needs maintainer approval
  • JDK-8355975 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset (Bug - P3)
  • JDK-8355975: ZipFile uses incorrect Charset if another instance for the same ZIP file was constructed with a different Charset (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/236/head:pull/236
$ git checkout pull/236

Update a local copy of the PR:
$ git checkout pull/236
$ git pull https://git.openjdk.org/jdk24u.git pull/236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 236

View PR using the GUI difftool:
$ git pr show -t 236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/236.diff

Using Webrev

Link to Webrev Comment

…on-UTF8 charset

8355975: ZipFile uses incorrect Charset if another instance for the same ZIP file was constructed with a different Charset

Co-authored-by: Eirik Bjørsnøs <[email protected]>
Reviewed-by: eirbjo, lancea, redestad, alanb
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2c4e8d211a030c85488e656a9a851d10dd0f9c11 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2025

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants