8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset

[jankratochvil]

Multithreaded handling of ZIP files can throw an exception.

This backport is far from clean. The last commit resolves the conflicts.

The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is a backward compatibility concern I have not backported it.

(jdk25 already contains it), this jdk21, jdk17.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8347712 needs maintainer approval
• JDK-8355975 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset (Bug - P3 - Requested)
• JDK-8355975: ZipFile uses incorrect Charset if another instance for the same ZIP file was constructed with a different Charset (Bug - P3 - Requested)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1949/head:pull/1949
$ git checkout pull/1949

Update a local copy of the PR:
$ git checkout pull/1949
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1949/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1949

View PR using the GUI difftool:
$ git pr show -t 1949

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1949.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[mlbridge]

Webrevs

• 00: Full (1752517b)

[openjdk]

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jankratochvil]

/approval request There is needed a backport for 21u to fix ZIP files handling. It is not a clean backport, last commit resolves the conflicts.

[openjdk]

@jankratochvil
8347712: The approval request has been created successfully.
8355975: The approval request has been created successfully.

[GoeLin]

Hi @jankratochvil
this is a larger change and just fresh in 25. Can we give this some time until January update?