refactor(inspector): separate inspector app from dashboard#4227
Conversation
|
🚅 Deployed to the rivet-pr-4227 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Test" took an action on this PR • (02/18/26)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
| @@ -0,0 +1 @@ | |||
| /Users/kwojciechowski/Documents/Projects/rivet.gg/rivet/frontend/public No newline at end of file | |||
There was a problem hiding this comment.
This file contains an absolute path to a local machine (/Users/kwojciechowski/Documents/Projects/rivet.gg/rivet/frontend/public). This will break for:
- Other developers checking out the code
- CI/CD pipelines
- Production deployments
Fix: Use a relative path for the symlink instead:
ln -s ../../public frontend/apps/inspector/publicOr configure the build tool to handle the public directory appropriately rather than committing a symlink.
| /Users/kwojciechowski/Documents/Projects/rivet.gg/rivet/frontend/public | |
| ../../public | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
PR Review: refactor(inspector): separate inspector app from dashboardGood separation of concerns overall — moving the inspector into its own standalone app makes the codebase cleaner. A few issues need addressing before merge. 🔴 Critical: Broken symlink with absolute local pathFile: The This breaks on every machine that isn't the author's. It should be a relative symlink, e.g. 🔴 Bug: Reconnect button calls
|
| Severity | Issue |
|---|---|
| 🔴 Critical | Broken absolute-path symlink for public/ |
| 🔴 Bug | Reconnect button calls disconnect() |
| 🟡 Bug | "go-to-actor" in schema vs "create-actor" in component |
| 🟡 Missing | package.json for the new inspector app |
| 🟡 Quality | HTTP links (should be HTTPS) and www. prefix on rivet.dev URLs |
| 🟡 Security | Missing noreferrer on external links |
| 🟢 Minor | Typo: "Whats new?" → "What's new?" |
| 🟢 Minor | Logo import ambiguity |
The symlink and reconnect button issues need to be fixed before merge. The rest are smaller but worth addressing in this PR since they're in new code.
6bbc16d to
73e303e
Compare
84d3f2b to
7c3c423
Compare
Merge activity
|
# Description Created a dedicated Inspector app in the frontend directory structure. This change moves the Inspector functionality from being embedded in the main frontend application to its own standalone app, allowing for better separation of concerns and more focused development. The new Inspector app includes: - A complete application structure with its own routing, components, and configuration - Dedicated HTML entry point and styling - Inspector-specific context providers and data handling - UI components for connecting to and interacting with local RivetKit instances This refactoring removes Inspector-related code from the main frontend codebase, including context providers, routes, and UI components that were previously shared. ## Type of change - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## How Has This Been Tested? The Inspector app has been tested by verifying it can: - Connect to local RivetKit instances - Display actor information - Handle connection status appropriately - Maintain all previous functionality in its new standalone form ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] New and existing unit tests pass locally with my changes

Description
Created a dedicated Inspector app in the frontend directory structure. This change moves the Inspector functionality from being embedded in the main frontend application to its own standalone app, allowing for better separation of concerns and more focused development.
The new Inspector app includes:
This refactoring removes Inspector-related code from the main frontend codebase, including context providers, routes, and UI components that were previously shared.
Type of change
How Has This Been Tested?
The Inspector app has been tested by verifying it can:
Checklist: