Skip to content

Comments

fix: invalid changelog ping position#4236

Open
jog1t wants to merge 1 commit intomainfrom
02-19-fix_invalid_changelog_ping_position
Open

fix: invalid changelog ping position#4236
jog1t wants to merge 1 commit intomainfrom
02-19-fix_invalid_changelog_ping_position

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Feb 19, 2026

No description provided.

@railway-app
Copy link

railway-app bot commented Feb 19, 2026

🚅 Deployed to the rivet-pr-4236 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector 😴 Sleeping (View Logs) Web Feb 24, 2026 at 7:09 pm
frontend-cloud 😴 Sleeping (View Logs) Web Feb 24, 2026 at 7:06 pm
ladle ❌ Build Failed (View Logs) Web Feb 24, 2026 at 6:58 pm
website 😴 Sleeping (View Logs) Web Feb 19, 2026 at 10:15 pm
mcp-hub ✅ Success (View Logs) Web Feb 19, 2026 at 10:04 pm

@jog1t jog1t marked this pull request as ready for review February 19, 2026 22:03
Copy link
Contributor Author

jog1t commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 19, 2026

Graphite Automations

"Test" took an action on this PR • (02/19/26)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

@claude
Copy link

claude bot commented Feb 19, 2026

PR Review: fix: invalid changelog ping position

This is a small, focused UI fix that correctly repositions the changelog ping indicator in the inspector sidebar.

Summary of Changes

frontend/apps/inspector/src/app/layout.tsx

  • Previously, the Ping component was rendered as a sibling before the HeaderButton, meaning its absolute positioning was relative to the outer flex container div rather than the button text.
  • The fix wraps the text in <span className="relative"> and places Ping inside, establishing the correct positioning context.
  • The className="-right-4" override makes sense — the Ping component has -right-3 as a default, but the additional offset accounts for visual alignment within the span.

frontend/tailwind.config.js

  • Adding "./apps/**/*.{ts,tsx}" to the content array is a necessary and correct companion to the layout fix. Without this, Tailwind's purge step would not scan the inspector app's files, meaning the -right-4 class (and any other Tailwind classes used in apps/) would be stripped from the production CSS bundle and the fix would silently break in production.

Feedback

Minor issues (pre-existing, not introduced by this PR):

  • "Whats new?" is missing an apostrophe — should be "What's new?". Worth fixing in a follow-up.
  • The changelog link uses rel="noopener" while the adjacent Documentation link uses rel="noopener noreferrer". For target="_blank" links, noreferrer is recommended to prevent leaking the referrer header. Worth making consistent.

The fix itself is correct — the Ping component is absolute positioned by default, so it requires a relative ancestor to anchor to. The previous placement outside the button meant the ping dot would float at an unexpected position in the sidebar layout.

No bugs, security concerns, or performance issues. The tailwind config change is particularly important to catch — good inclusion.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 19, 2026

More templates

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4236

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4236

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4236

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4236

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4236

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4236

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4236

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4236

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4236

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4236

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4236

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4236

commit: 0b57fb1

@jog1t jog1t force-pushed the 02-19-refactor_inspector_serve_inspector_from_manager_localhost_6420_ui_ branch from 4a58c66 to 6a877f5 Compare February 19, 2026 22:12
@jog1t jog1t force-pushed the 02-19-fix_invalid_changelog_ping_position branch from 3393c63 to 1ca1dcf Compare February 19, 2026 22:22
@jog1t jog1t force-pushed the 02-19-refactor_inspector_serve_inspector_from_manager_localhost_6420_ui_ branch from 6a877f5 to d4eab78 Compare February 19, 2026 22:22
@jog1t jog1t force-pushed the 02-19-fix_invalid_changelog_ping_position branch from 1ca1dcf to 0b57fb1 Compare February 19, 2026 22:31
@jog1t jog1t force-pushed the 02-19-refactor_inspector_serve_inspector_from_manager_localhost_6420_ui_ branch from d4eab78 to 76f77cc Compare February 19, 2026 22:31
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4236 February 19, 2026 22:31 Destroyed
@NathanFlurry NathanFlurry changed the base branch from 02-19-refactor_inspector_serve_inspector_from_manager_localhost_6420_ui_ to graphite-base/4236 February 19, 2026 23:05
@jog1t jog1t force-pushed the 02-19-fix_invalid_changelog_ping_position branch from 0b57fb1 to f576ad0 Compare February 24, 2026 18:57
@jog1t jog1t force-pushed the graphite-base/4236 branch from 76f77cc to 5c11e8e Compare February 24, 2026 18:57
@jog1t jog1t changed the base branch from graphite-base/4236 to main February 24, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant