Conversation
railway-app
bot
temporarily deployed
to
rivet-frontend / rivet-pr-4248
|
🚅 Deployed to the rivet-pr-4248 environment in rivet-frontend
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
Graphite Automations"Test" took an action on this PR • (02/20/26)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
# Description This change removes several tabs from the actor details interface, including Queue, Traces, Workflow, and Database tabs. The corresponding tab triggers and content sections have been removed from the UI. Additionally, the import for `ActorWorkflowTab` has been moved to maintain proper import organization. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes
graphite-app
bot
deleted the
02-20-fix_dashboard_hide_unsupported_tabs
branch
PR Review: fix(dashboard): hide unsupported tabsSummaryThis PR removes Queue, Traces, Workflow, and Database tabs from the actor details UI. The change is straightforward, but there are a few issues to address. IssuesUnused Imports (Bug)After removing the tab content components, several imports remain in the file that are now dead code. This will likely produce TypeScript/ESLint warnings or errors: // These are imported but no longer used after this PR:
import { ActorDatabaseTab } from "./actor-db-tab";
import { ActorQueueTab } from "./actor-queue-tab";
import { ActorTracesTab } from "./actor-traces-tab";
import { ActorWorkflowTab } from "./workflow/actor-workflow-tab"; // moved but still unusedThe PR description says the Permanently Deleted vs. Commented-Out CodeTwo tabs (Logs, Metrics) were previously commented out—presumably with intent to restore them later. This PR deletes those comments entirely alongside the active tabs. If there's any chance Queue, Traces, Workflow, or Database will be re-enabled, the same approach (commenting out) would be more consistent. If these are being permanently removed, that's fine—but worth confirming intent. Minor Notes
VerdictThe core change is correct, but the unused imports should be cleaned up before merging. Everything else is minor. |
1 participant
Description
This change removes several tabs from the actor details interface, including Queue, Traces, Workflow, and Database tabs. The corresponding tab triggers and content sections have been removed from the UI. Additionally, the import for
ActorWorkflowTabhas been moved to maintain proper import organization.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: