feat(dashboard): bring new tabs back#4249
feat(dashboard): bring new tabs back#4249jog1t wants to merge 1 commit into02-22-fix_rivetkit_fix_sqlite_teardown_logicfrom
Conversation
|
🚅 Deployed to the rivet-pr-4249 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
5abc065 to
6f381dc
Compare
b44bfe0 to
101e380
Compare
PR Review: feat(dashboard): bring new tabs backOverall: The PR is simple and mostly correct, but has one clear bug and a minor structural issue worth addressing. Bug: Database tab content is unreachableA // This was added — but there's no TabsTrigger for "database"
<TabsContent
value="database"
className="min-h-0 min-w-0 flex-1 mt-0 h-full"
>
{guardContent || <ActorDatabaseTab actorId={actorId} />}
</TabsContent>A trigger like the following is missing from the <TabsTrigger
disabled={disabled}
value="database"
className="text-xs px-3 py-1 pb-2"
>
Database
</TabsTrigger>Minor: Logs tab also lacks a trigger (pre-existing)Not introduced by this PR, but worth noting: there's also a Positives
|
101e380 to
05641ac
Compare
Graphite Automations"Test" took an action on this PR • (02/20/26)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
05641ac to
36d8116
Compare
6a2b467 to
36d8116
Compare
6840f4f to
81946f1
Compare
36d8116 to
1acf842
Compare
1acf842 to
8b03cc7
Compare
81946f1 to
854e432
Compare
8b03cc7 to
16a20a8
Compare
854e432 to
81946f1
Compare
16a20a8 to
1acf842
Compare
81946f1 to
cdb63b8
Compare
1acf842 to
93584bb
Compare
93584bb to
00b7bcc
Compare
cdb63b8 to
48bfc9a
Compare
48bfc9a to
81946f1
Compare
00b7bcc to
1acf842
Compare
Merge activity
|
# Description This change adds new tabs to the actor details interface, specifically adding Queue, Workflow, and Database tabs alongside the existing tabs. The implementation includes both the tab triggers in the navigation and their corresponding content components. Additionally, an unused import for `useQuery` from `@tanstack/react-query` and the `ActorTracesTab` import have been removed. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes

Description
This change adds new tabs to the actor details interface, specifically adding Queue, Workflow, and Database tabs alongside the existing tabs. The implementation includes both the tab triggers in the navigation and their corresponding content components. Additionally, an unused import for
useQueryfrom@tanstack/react-queryand theActorTracesTabimport have been removed.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: