Skip to content

feat(dashboard): bring new tabs back#4249

Closed
jog1t wants to merge 1 commit into02-22-fix_rivetkit_fix_sqlite_teardown_logicfrom
02-20-feat_dashboard_bring_new_tabs_back
Closed

feat(dashboard): bring new tabs back#4249
jog1t wants to merge 1 commit into02-22-fix_rivetkit_fix_sqlite_teardown_logicfrom
02-20-feat_dashboard_bring_new_tabs_back

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Feb 20, 2026

Description

This change adds new tabs to the actor details interface, specifically adding Queue, Workflow, and Database tabs alongside the existing tabs. The implementation includes both the tab triggers in the navigation and their corresponding content components. Additionally, an unused import for useQuery from @tanstack/react-query and the ActorTracesTab import have been removed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4249 February 20, 2026 22:29 Destroyed
@railway-app
Copy link

railway-app bot commented Feb 20, 2026

🚅 Deployed to the rivet-pr-4249 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector 😴 Sleeping (View Logs) Web Feb 23, 2026 at 11:17 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 23, 2026 at 11:08 pm
ladle ❌ Build Failed (View Logs) Web Feb 23, 2026 at 11:06 pm
website ❌ Build Failed (View Logs) Web Feb 20, 2026 at 10:31 pm
mcp-hub ✅ Success (View Logs) Web Feb 20, 2026 at 10:31 pm

@jog1t jog1t marked this pull request as ready for review February 20, 2026 22:30
Copy link
Contributor Author

jog1t commented Feb 20, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t mentioned this pull request Feb 20, 2026
11 tasks
@graphite-app graphite-app bot changed the base branch from 02-20-fix_dashboard_hide_unsupported_tabs to graphite-base/4249 February 20, 2026 22:31
@graphite-app graphite-app bot force-pushed the graphite-base/4249 branch from 5abc065 to 6f381dc Compare February 20, 2026 22:32
@graphite-app graphite-app bot force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from b44bfe0 to 101e380 Compare February 20, 2026 22:32
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4249 February 20, 2026 22:32 Destroyed
@claude
Copy link

claude bot commented Feb 20, 2026

PR Review: feat(dashboard): bring new tabs back

Overall: The PR is simple and mostly correct, but has one clear bug and a minor structural issue worth addressing.


Bug: Database tab content is unreachable

A TabsContent block is added for value="database" (rendering <ActorDatabaseTab>) but no corresponding TabsTrigger with value="database" was added to the TabsList. The existing triggers in the nav bar are: State, Connections, Queue, Workflow, Metadata — Database is absent. This means the Database tab is completely inaccessible in the UI despite the content being wired up.

// This was added — but there's no TabsTrigger for "database"
<TabsContent
    value="database"
    className="min-h-0 min-w-0 flex-1 mt-0 h-full"
>
    {guardContent || <ActorDatabaseTab actorId={actorId} />}
</TabsContent>

A trigger like the following is missing from the TabsList:

<TabsTrigger
    disabled={disabled}
    value="database"
    className="text-xs px-3 py-1 pb-2"
>
    Database
</TabsTrigger>

Minor: Logs tab also lacks a trigger (pre-existing)

Not introduced by this PR, but worth noting: there's also a TabsContent for value="logs" with no matching trigger in the current nav. If logs are intentionally hidden, the content block should be removed too; if not, the trigger is missing. This PR would be a good opportunity to fix both gaps.


Positives

  • Removing the unused useQuery and ActorTracesTab imports is a clean-up.
  • The queue and workflow tab wiring (trigger + content) looks correct and consistent with the existing connections tab pattern.
  • The individual tab components (ActorQueueTab, ActorWorkflowTab, ActorDatabaseTab) each handle their own loading/disabled/error states properly.

@graphite-app graphite-app bot changed the base branch from graphite-base/4249 to main February 20, 2026 22:33
@graphite-app graphite-app bot force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 101e380 to 05641ac Compare February 20, 2026 22:33
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4249 February 20, 2026 22:33 Destroyed
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 20, 2026

Graphite Automations

"Test" took an action on this PR • (02/20/26)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

@NathanFlurry NathanFlurry changed the base branch from main to graphite-base/4249 February 22, 2026 21:06
@NathanFlurry NathanFlurry force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 05641ac to 36d8116 Compare February 22, 2026 21:06
@NathanFlurry NathanFlurry changed the base branch from graphite-base/4249 to 02-22-fix_rivetkit_fix_sqlite_teardown_logic February 22, 2026 21:07
@NathanFlurry NathanFlurry changed the base branch from 02-22-fix_rivetkit_fix_sqlite_teardown_logic to graphite-base/4249 February 23, 2026 06:40
@NathanFlurry NathanFlurry force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 6a2b467 to 36d8116 Compare February 23, 2026 18:34
@NathanFlurry NathanFlurry force-pushed the 02-22-fix_rivetkit_fix_sqlite_teardown_logic branch from 6840f4f to 81946f1 Compare February 23, 2026 18:35
@NathanFlurry NathanFlurry force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 36d8116 to 1acf842 Compare February 23, 2026 18:35
@jog1t jog1t force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 1acf842 to 8b03cc7 Compare February 23, 2026 23:02
@jog1t jog1t force-pushed the 02-22-fix_rivetkit_fix_sqlite_teardown_logic branch from 81946f1 to 854e432 Compare February 23, 2026 23:02
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4249 February 23, 2026 23:02 Destroyed
@jog1t jog1t force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 8b03cc7 to 16a20a8 Compare February 23, 2026 23:05
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4249 February 23, 2026 23:05 Destroyed
@NathanFlurry NathanFlurry force-pushed the 02-22-fix_rivetkit_fix_sqlite_teardown_logic branch from 854e432 to 81946f1 Compare February 23, 2026 23:34
@NathanFlurry NathanFlurry force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 16a20a8 to 1acf842 Compare February 23, 2026 23:34
@NathanFlurry NathanFlurry force-pushed the 02-22-fix_rivetkit_fix_sqlite_teardown_logic branch from 81946f1 to cdb63b8 Compare February 24, 2026 02:39
@NathanFlurry NathanFlurry force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 1acf842 to 93584bb Compare February 24, 2026 02:40
@NathanFlurry NathanFlurry mentioned this pull request Feb 24, 2026
11 tasks
@NathanFlurry NathanFlurry force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 93584bb to 00b7bcc Compare February 24, 2026 02:57
@NathanFlurry NathanFlurry force-pushed the 02-22-fix_rivetkit_fix_sqlite_teardown_logic branch from cdb63b8 to 48bfc9a Compare February 24, 2026 02:57
@NathanFlurry NathanFlurry force-pushed the 02-22-fix_rivetkit_fix_sqlite_teardown_logic branch from 48bfc9a to 81946f1 Compare February 24, 2026 03:19
@NathanFlurry NathanFlurry force-pushed the 02-20-feat_dashboard_bring_new_tabs_back branch from 00b7bcc to 1acf842 Compare February 24, 2026 03:19
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 24, 2026

Merge activity

  • Feb 24, 3:21 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Feb 24, 3:22 AM UTC: CI is running for this pull request on a draft pull request (#4274) due to your merge queue CI optimization settings.
  • Feb 24, 3:23 AM UTC: Merged by the Graphite merge queue via draft PR: #4274.

graphite-app bot pushed a commit that referenced this pull request Feb 24, 2026
# Description

This change adds new tabs to the actor details interface, specifically adding Queue, Workflow, and Database tabs alongside the existing tabs. The implementation includes both the tab triggers in the navigation and their corresponding content components. Additionally, an unused import for `useQuery` from `@tanstack/react-query` and the `ActorTracesTab` import have been removed.

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
@graphite-app graphite-app bot closed this Feb 24, 2026
@graphite-app graphite-app bot deleted the 02-20-feat_dashboard_bring_new_tabs_back branch February 24, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant