chore(rivetkit): enforce limits on fs driver kv api to match engine#4273
Conversation
|
🚅 Deployed to the rivet-pr-4273 environment in rivet-frontend
|
PR Review: enforce limits on fs driver KV API to match engineGood change — enforcing consistent KV limits between the filesystem driver and the production engine is important for catching limit-related bugs during local development. The new Issues
The function loops over entries once to compute Storage size estimate excludes key wrapper overhead
For a local dev driver this is acceptable, but it means users could hit storage-full errors from the engine at slightly different thresholds than locally. Worth a comment noting this: // Note: measures raw key/value bytes. The production engine uses FDB's estimated
// size which includes encoding overhead, so thresholds may differ slightly.Missing human-readable comment on The Rust constant has Nit: Inconsistent error message casing
No issues with
|
ff102a7 to
eb05d8d
Compare
43fa711 to
cd347ac
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: