fix(udb): add txn tagging#4328
fix(udb): add txn tagging#4328MasterPtato wants to merge 1 commit into02-27-fix_api_make_actor_destroy_wait_for_ackfrom
Conversation
|
🚅 Deployed to the rivet-pr-4328 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Review: fix(udb): add txn taggingThis is a small, focused PR that adds a ObservationsNo driver implementations Neither If it's a stub, that's fine — but consider whether the silent no-op could cause confusion for callers who expect tagging to affect observability. Relationship to
Comment style (minor) Per the project conventions, the comment Missing docstring on the trait method The SummaryThe interface is clean and consistent with the rest of the module. The main open question is whether this is intentionally a no-op stub (to be wired up to metrics/tracing in a follow-up) or if there's a concrete use case where the default no-op is expected to be sufficient. If the former, a TODO comment pointing to the intended implementation would add clarity. |
|
This change is part of the following stack: Change managed by git-spice. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: