Skip to content

chore: bump rivetkit protocol version#4329

Open
MasterPtato wants to merge 1 commit into02-27-fix_udb_add_txn_taggingfrom
02-27-chore_bump_rivetkit_protocol_version
Open

chore: bump rivetkit protocol version#4329
MasterPtato wants to merge 1 commit into02-27-fix_udb_add_txn_taggingfrom
02-27-chore_bump_rivetkit_protocol_version

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor Author

MasterPtato commented Feb 27, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@railway-app
Copy link

railway-app bot commented Feb 27, 2026

🚅 Deployed to the rivet-pr-4329 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 27, 2026 at 11:58 pm
frontend-inspector 😴 Sleeping (View Logs) Web Feb 27, 2026 at 11:57 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 27, 2026 at 11:51 pm
mcp-hub ✅ Success (View Logs) Web Feb 27, 2026 at 11:50 pm
ladle ❌ Build Failed (View Logs) Web Feb 27, 2026 at 11:49 pm

@claude
Copy link

claude bot commented Feb 27, 2026

PR Review: chore: bump rivetkit protocol version

This is a small, focused PR with two changes. Both look correct.

Change 1: Protocol version bump (v5 → v6)

The bump in engine/sdks/typescript/runner/src/mod.ts aligns the TypeScript runner with the server's latest protocol version. The Rust engine already has full v6 support, including:

  • v5_to_v6 / v6_to_v5 converters in engine/sdks/rust/runner-protocol/src/versioned.rs
  • v6 adds actor_stop_threshold and serverless_drain_grace_period to ProtocolMetadata

No concerns here — the server correctly handles both v5 and v6 clients via the converter chain.

Change 2: Serverless URL path fix

The fix in engine/sdks/typescript/test-runner/src/index.ts corrects a bug: the URL was missing the /api/rivet prefix, so the engine (which appends /start and /metadata to the base URL) was calling nonexistent routes. The actual routes are registered at /api/rivet/start and /api/rivet/metadata, so the base URL should use the /api/rivet prefix.

The Rust serverless code properly trims trailing slashes before appending (url.trim_end_matches(/)), so no double-slash risk.

Minor observation

The PR description template has not been filled in (checklist, test plan, etc.) — fine for a small chore PR, but worth noting for larger changes in the future.

Overall: LGTM. Both changes are correct and minimal.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4329

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4329

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4329

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4329

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4329

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4329

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4329

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4329

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4329

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4329

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4329

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4329

commit: d1f7b22

@MasterPtato
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant