fix: get stuff building #2020

MasterPtato · 2025-02-12T00:59:34Z

Changes

cloudflare-workers-and-pages · 2025-02-12T00:59:36Z

Deploying rivet with Cloudflare Pages

Latest commit:	`b9f0ded`
Status:	🚫 Build failed.

View logs

MasterPtato · 2025-02-12T01:00:02Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-02-12T01:02:21Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`b9f0ded`
Status:	✅ Deploy successful!
Preview URL:	https://a1ddfd54.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://02-12-fix-get-stuff-building.rivet-hub-7jb.pages.dev

View logs

greptile-apps

PR Summary

This PR focuses on fixing build issues across the Rivet codebase by updating dependencies and modifying database configurations, particularly around FoundationDB and reqwest HTTP client.

Switches from musl to glibc in edge server Dockerfiles for Linode compatibility, updating from Rust 1.81.0 to 1.82.0
Makes FoundationDB configuration optional across multiple services with proper handling in pools and test contexts
Updates reqwest from 0.11 to 0.12 consistently across all packages while maintaining feature flags
Adds comprehensive database migrations for DS service with new tables and indexes, though several down migrations are missing rollback logic
Temporarily switches to LSilent/cloudflare-rs fork until PR [RVT-3410] Implement realtime container metrics #256 is merged in official repo

_{58 file(s) reviewed, 29 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-14T23:43:49Z

frontend/apps/hub/package.json

@@ -4,7 +4,7 @@
 	"version": "0.0.0",
 	"type": "module",
 	"scripts": {
-		"dev": "vite",
+		"dev": "strace -o strace.log -f vite",


style: using strace in development may significantly slow down the development server and generate large log files

greptile-apps · 2025-02-14T23:44:00Z

packages/common/chirp-workflow/core/src/ctx/test.rs

+			let mut root = rivet_config::config::Root::default();
+			root.server.as_mut().unwrap().foundationdb = Some(Default::default());
+			let config = rivet_config::Config::from_root(root);


logic: Ensure Default::default() for FoundationDB provides all required fields for test environments. Missing required fields could cause runtime issues.

greptile-apps · 2025-02-14T23:44:00Z

packages/common/config/src/config/server/mod.rs

@@ -40,7 +40,7 @@ pub struct Server {
 	#[serde(default)]
 	pub prometheus: Option<Prometheus>,
 	#[serde(default)]
-	pub foundationdb: FoundationDb,
+	pub foundationdb: Option<FoundationDb>,


style: Missing a corresponding getter method like other optional fields (e.g. fn foundationdb(&self) -> GlobalResult<&FoundationDb>)

greptile-apps · 2025-02-14T23:44:00Z

packages/common/chirp-workflow/core/src/ctx/test.rs

 			let pools = rivet_pools::Pools::test(config.clone())
 				.await
 				.expect("failed to create pools");


style: Consider adding error context to the expect() message to clarify what specific pool creation failed

greptile-apps · 2025-02-14T23:44:50Z

packages/common/hub-embed/build.rs

+	// println!("Running yarn build");
+	// let output = Command::new("yarn")
+	// 	.current_dir(&hub_path)
+	// 	.args(["dlx", "turbo", "run", "build:embedded"])
+	// 	.env("VITE_APP_API_URL", "__APP_API_URL__")
+	// 	.output()?;
+	// println!("stdout:\n{}", String::from_utf8_lossy(&output.stdout));
+	// println!("stderr:\n{}", String::from_utf8_lossy(&output.stderr));
+	// assert!(output.status.success(), "hub build failed");


logic: commenting out build step breaks hub application deployment - either uncomment or provide alternative build mechanism

greptile-apps · 2025-02-14T23:57:30Z

packages/edge/services/ds/db/ds/migrations/20241028133100_rename_tables.up.sql

+ALTER TABLE docker_ports_protocol_game_guard
+	ALTER COLUMN port_number DROP NOT NULL;


logic: Making port_number nullable could cause runtime errors if any code assumes this field is always populated. Verify all consumers of this field handle null values appropriately.

greptile-apps · 2025-02-14T23:57:34Z

packages/edge/services/ds/db/ds/migrations/20241030122600_gg_port_auth.up.sql

+	server_id UUID NOT NULL,
+	port_name TEXT NOT NULL,
+	auth_type INT NOT NULL,
+	key TEXT,


style: Consider adding NOT NULL constraint to key if it's required for certain auth_type values

greptile-apps · 2025-02-14T23:58:22Z

packages/edge/services/ds/db/ds/migrations/20250204185326_game_config_def.up.sql

+ALTER TABLE game_config
+ALTER COLUMN runtime SET DEFAULT 0;


logic: Setting a default value of 0 for runtime may cause issues if 0 is not a valid runtime type in the application. Consider using a known valid runtime value or making the column non-nullable with an explicit valid default.

greptile-apps · 2025-02-14T23:58:41Z

packages/edge/services/ds/db/ds/migrations/20241115184305_add_durable.up.sql

+	RENAME COLUMN kill_timeout_ms TO lifecycle_kill_timeout_ms,
+	ADD COLUMN lifecycle_durable BOOLEAN NOT NULL DEFAULT false,
+	ADD COLUMN reschedule_retry_count INT NOT NULL DEFAULT 0,
+	ADD COLUMN last_reschedule_retry_ts INT;


logic: last_reschedule_retry_ts should have a NOT NULL constraint since it's used for tracking timestamps

greptile-apps · 2025-02-14T23:58:42Z

packages/edge/services/ds/db/ds/migrations/20241115184305_add_durable.up.sql

+	RENAME COLUMN kill_timeout_ms TO lifecycle_kill_timeout_ms,
+	ADD COLUMN lifecycle_durable BOOLEAN NOT NULL DEFAULT false,
+	ADD COLUMN reschedule_retry_count INT NOT NULL DEFAULT 0,
+	ADD COLUMN last_reschedule_retry_ts INT;


style: Consider adding a CHECK constraint to ensure last_reschedule_retry_ts is a valid Unix timestamp

MasterPtato mentioned this pull request Feb 12, 2025

fix(cluster): write install script for worker pool #2009

Open

MasterPtato force-pushed the 02-12-fix_get_stuff_building branch from 92b5360 to 290658d Compare February 12, 2025 01:47

This was referenced Feb 13, 2025

fix: get tunnels working, fix tls, wf bug fix #2025

Open

fix: get actors running e2e on edge #2027

Open

MasterPtato marked this pull request as ready for review February 14, 2025 23:42

MasterPtato requested a review from NathanFlurry February 14, 2025 23:42

MasterPtato mentioned this pull request Feb 14, 2025

fix: get edge api access over gg #2032

Open

greptile-apps bot reviewed Feb 14, 2025

View reviewed changes

MasterPtato mentioned this pull request Feb 15, 2025

feat(workflows): abstract debug trait #2033

Open

MasterPtato force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 741ef37 to 0618a18 Compare February 15, 2025 01:52

MasterPtato force-pushed the 02-12-fix_get_stuff_building branch from 290658d to 55a330f Compare February 15, 2025 01:52

MasterPtato force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 0618a18 to 72e6e1e Compare February 18, 2025 02:32

MasterPtato force-pushed the 02-12-fix_get_stuff_building branch from 55a330f to 95ef81c Compare February 18, 2025 02:32

MasterPtato mentioned this pull request Feb 18, 2025

feat(workflows): impl db debug for fdb driver #2040

Open

NathanFlurry force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 72e6e1e to d4e7b15 Compare February 19, 2025 02:59

NathanFlurry force-pushed the 02-12-fix_get_stuff_building branch from 95ef81c to 08b4e1f Compare February 19, 2025 02:59

This was referenced Feb 19, 2025

chore: add native fdb library to path #2045

Open

chore: add fdb-backed sqlite driver #2046

Open

NathanFlurry changed the base branch from 02-11-fix_cluster_write_install_script_for_worker_pool to graphite-base/2020 February 19, 2025 05:16

This was referenced Feb 19, 2025

chore: add timeout flag to docker-compose down #2048

Open

fix: force amd64 platform for FDB tests #2049

Open

MasterPtato force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 9936cb1 to 807badd Compare February 25, 2025 02:45

MasterPtato force-pushed the 02-12-fix_get_stuff_building branch from 61641ee to 6a57b86 Compare February 25, 2025 02:45

MasterPtato mentioned this pull request Feb 25, 2025

fix: add metrics for wf engine #2076

Open

NathanFlurry force-pushed the 02-12-fix_get_stuff_building branch from 6a57b86 to d8bf651 Compare February 26, 2025 01:05

NathanFlurry force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 807badd to 9510430 Compare February 26, 2025 01:05

NathanFlurry mentioned this pull request Feb 26, 2025

chore(pools): rewrite sqlite manager to run without locks using scc #2082

Open

fix: get stuff building

b9f0ded

MasterPtato force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 9510430 to 780c0b1 Compare February 26, 2025 03:27

MasterPtato force-pushed the 02-12-fix_get_stuff_building branch from d8bf651 to b9f0ded Compare February 26, 2025 03:27

MasterPtato mentioned this pull request Feb 26, 2025

feat: add grafana to docker compose #2083

Open

NathanFlurry force-pushed the 02-12-fix_get_stuff_building branch from b9f0ded to d8bf651 Compare February 26, 2025 06:18

NathanFlurry force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch 2 times, most recently from 9510430 to 10954e3 Compare February 27, 2025 00:49

NathanFlurry force-pushed the 02-12-fix_get_stuff_building branch from d8bf651 to 228ff44 Compare February 27, 2025 00:49

This was referenced Feb 27, 2025

chore(hub-embed): disable all node-related code if hub building is disabled #2084

Open

chore(runtime): add otel support to runtime #2085

Open

MasterPtato force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 10954e3 to 780c0b1 Compare February 27, 2025 02:42

MasterPtato force-pushed the 02-12-fix_get_stuff_building branch from 228ff44 to b9f0ded Compare February 27, 2025 02:42

MasterPtato mentioned this pull request Feb 27, 2025

chore: optimizations and such #2086

Open

NathanFlurry force-pushed the 02-12-fix_get_stuff_building branch from b9f0ded to d8bf651 Compare February 27, 2025 07:59

NathanFlurry force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 780c0b1 to 9510430 Compare February 27, 2025 07:59

NathanFlurry mentioned this pull request Feb 27, 2025

fix(runtime): remove forcing tokio core count to 2 #2087

Open

MasterPtato force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 9510430 to 780c0b1 Compare February 27, 2025 18:55

MasterPtato force-pushed the 02-12-fix_get_stuff_building branch from d8bf651 to b9f0ded Compare February 27, 2025 18:55

NathanFlurry force-pushed the 02-12-fix_get_stuff_building branch from b9f0ded to d8bf651 Compare February 27, 2025 20:45

NathanFlurry force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 780c0b1 to 9510430 Compare February 27, 2025 20:46

NathanFlurry mentioned this pull request Feb 27, 2025

fix(docker): auto-create otel database #2088

Open

MasterPtato force-pushed the 02-11-fix_cluster_write_install_script_for_worker_pool branch from 9510430 to 780c0b1 Compare February 28, 2025 03:05

MasterPtato force-pushed the 02-12-fix_get_stuff_building branch from d8bf651 to b9f0ded Compare February 28, 2025 03:05

MasterPtato mentioned this pull request Feb 28, 2025

chore: combine ds into pb #2089

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: get stuff building #2020

fix: get stuff building #2020

MasterPtato commented Feb 12, 2025

cloudflare-workers-and-pages bot commented Feb 12, 2025 •

edited

Loading

MasterPtato commented Feb 12, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 12, 2025 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

		ALTER TABLE docker_ports_protocol_game_guard
		ALTER COLUMN port_number DROP NOT NULL;

fix: get stuff building #2020

Are you sure you want to change the base?

fix: get stuff building #2020

Conversation

MasterPtato commented Feb 12, 2025

Changes

cloudflare-workers-and-pages bot commented Feb 12, 2025 • edited Loading

Deploying rivet with Cloudflare Pages

MasterPtato commented Feb 12, 2025 • edited Loading

How to use the Graphite Merge Queue

cloudflare-workers-and-pages bot commented Feb 12, 2025 • edited Loading

Deploying rivet-hub with Cloudflare Pages

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Feb 12, 2025 •

edited

Loading

MasterPtato commented Feb 12, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 12, 2025 •

edited

Loading