chore(runtime): add otel support to runtime #2085

NathanFlurry · 2025-02-27T00:51:25Z

Changes

NathanFlurry · 2025-02-27T00:52:17Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

This PR adds OpenTelemetry support to the Rivet runtime, enabling distributed tracing, metrics, and logging capabilities for improved observability.

Added new otel.rs module that configures tracer, meter, and logger providers with GRPC export to configurable endpoint
Simplified runtime initialization by removing RunConfig struct and replacing with direct run() calls
Fixed error handling in server main functions by correcting double question mark (??) issues
Added multiple OpenTelemetry-related dependencies in Cargo.toml including exporters and semantic conventions
Removed RivetRuntime error variant from ManagerError enum as part of error handling refactoring

_{8 file(s) reviewed, 9 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-27T00:52:03Z

packages/common/runtime/Cargo.toml

+opentelemetry = { version = "0.28", features = ["trace", "metrics", "logs"] }
+opentelemetry-otlp = { version = "0.28", features = ["trace", "metrics", "logs", "grpc-tonic"] }
+opentelemetry-semantic-conventions = { version = "0.28", features = ["semconv_experimental"] }
+opentelemetry-stdout = { version = "0.28.0", features = ["trace", "metrics", "logs"] }


style: The version for opentelemetry-stdout includes a patch version (0.28.0) while other opentelemetry packages use just 0.28. Consider using consistent versioning across all opentelemetry packages.

greptile-apps · 2025-02-27T00:52:36Z

packages/common/runtime/src/lib.rs

@@ -1,157 +1,71 @@
-use std::{env, future::Future, sync::Once, time::Duration};
+use std::{env, future::Future, time::Duration, process};


style: The process module is imported but not used anywhere in the code

Suggested change

use std::{env, future::Future, time::Duration, process};

use std::{env, future::Future, time::Duration};

greptile-apps · 2025-02-27T00:52:38Z

packages/common/runtime/src/lib.rs

+	});
+
+	if let Ok(thread_stack_size) = env::var("TOKIO_THREAD_STACK_SIZE") {
+		rt_builder.thread_stack_size(thread_stack_size.parse().unwrap());


logic: Using unwrap() here will cause a panic if the environment variable contains an invalid integer. The previous implementation returned a Result with a proper error message.

greptile-apps · 2025-02-27T00:52:39Z

packages/common/runtime/src/lib.rs

-			}
-		})
+	if let Ok(worker_threads) = env::var("TOKIO_WORKER_THREADS") {
+		rt_builder.worker_threads(worker_threads.parse().unwrap());


logic: Same issue with unwrap() - this will panic on invalid input rather than returning an error like the previous implementation

greptile-apps · 2025-02-27T00:52:41Z