-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(hub-embed): disable all node-related code if hub building is disabled #2084
base: 02-27-chore_optimizations_and_such
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies the codebase to conditionally disable node-related operations when hub building is skipped, improving build efficiency and error handling.
- Changed
backend_dispatcher_namespace
inCloudflare
struct fromString
toOption<String>
inpackages/common/config/src/config/server/mod.rs
- Added conditional logic in
packages/common/hub-embed/build.rs
to skip node operations whenRIVET_SKIP_BUILD_HUB
is set - Improved error handling in
packages/core/services/cluster/src/workflows/datacenter/mod.rs
with early returns and warning logs instead of macros - Fixed directory management in build script to create empty output directory when hub building is skipped
- Bug in error message for
drain_timeout
check incorrectly referencesmax_count
instead ofdrain_timeout
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
let Some(drain_timeout) = pool.drain_timeout else { | ||
tracing::warn!("must have `max_count` when creating a new pool"); | ||
return Ok(()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The error message incorrectly refers to max_count
instead of drain_timeout
let Some(drain_timeout) = pool.drain_timeout else { | |
tracing::warn!("must have `max_count` when creating a new pool"); | |
return Ok(()); | |
let Some(drain_timeout) = pool.drain_timeout else { | |
tracing::warn!("must have `drain_timeout` when creating a new pool"); | |
return Ok(()); |
31a5aa7
to
e4f0825
Compare
f299ca1
to
9b7cef1
Compare
e4f0825
to
9a1c93b
Compare
Deploying rivet-hub with
|
Latest commit: |
9b7cef1
|
Status: | ✅ Deploy successful! |
Preview URL: | https://7421eef8.rivet-hub-7jb.pages.dev |
Branch Preview URL: | https://02-21-chore-hub-embed-disabl.rivet-hub-7jb.pages.dev |
9a1c93b
to
69e7475
Compare
9b7cef1
to
d02c977
Compare
d02c977
to
8c0f338
Compare
a452771
to
58504c6
Compare
58504c6
to
a452771
Compare
8c0f338
to
d02c977
Compare
Changes