-
Notifications
You must be signed in to change notification settings - Fork 152
Add Other Logging Implementations #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Other Logging Implementations #858
Conversation
Signed-off-by: Michael Carlstrom <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, otherwise this looks good
Signed-off-by: Michael Carlstrom <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Pulls: #858 |
The test failures are unrelated. Thanks for the PR! |
Pulls: #858 |
So I just noticed that I didn't properly test this: the first CI run is testing branch I think this PR would be fine, but it uses |
This reverts commit b7b31c4.
Reverted in #865. We'll see if CI passes above, but just based on the minimum Python requirement, we'll have to find an alternative to @InvincibleRMC would you be willing to open another PR that doesn't use |
Yeah definitely. |
So it does fail on RHEL: https://ci.ros2.org/job/ci_linux-rhel/2748/testReport/junit/launch.test.launch.actions/test_log/test_log_execute/. Windows will probably fail too, knowing that it has an older Python version, but I'll just cancel it. |
Added generic
Log
class and Specializations forLogInfo
,LogDebug
,LogError
,LogWarning
.Closes #821