-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update dependecies #5595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Update dependecies #5595
Conversation
70818c3
to
098a31a
Compare
MarkupSafe==2.0.1 | ||
packaging==21.3 | ||
pbr==5.8.0 | ||
alabaster==0.7.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed dependencies to latest available versions because they are working with all tools (didn't worked with the apt version out of the box). Or is there a specific reason to stick to the dep availible via apt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's OK here if it works, especially since 24.04 is the latest Ubuntu LTS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
however, for traceability, can you provide the commands you ran to bump the versions and update the constraints.txt
file?
I did this in a ubuntu:22.04
container after installing python3-pip
and python3-venv
:
$ python3 -m venv venv
$ . ./venv/bin/activate
$ pip3 install -r requirements.txt -c constraints.txt
$ pip3 install -U -r requirements.txt
$ pip3 freeze > constraints.txt
and the result is a bit different:
diff --git a/constraints.txt b/constraints.txt
index 1e3e88b3..bbc03a66 100644
--- a/constraints.txt
+++ b/constraints.txt
@@ -1,34 +1,30 @@
-alabaster==0.7.16
-atomicwrites==1.4.1
-attrs==25.3.0
-babel==2.17.0
-certifi==2025.4.26
+alabaster==1.0.0
+Babel==2.14.0
+certifi==2020.6.20
+chardet==4.0.0
charset-normalizer==3.4.2
-click==8.1.8
+click==8.2.1
codespell==2.4.1
-doc8==1.1.2
+doc8==2.0.0
docutils==0.21.2
-idna==3.10
-imagesize==1.4.1
+idna==2.10
+imagesize==1.3.0
iniconfig==2.1.0
Jinja2==3.1.6
-MarkupSafe==3.0.2
-more-itertools==10.7.0
+MarkupSafe==2.0.1
packaging==25.0
-pbr==6.1.1
-pluggy==1.5.0
+pbr==5.8.0
+pluggy==1.6.0
polib==1.2.0
-py==1.11.0
-Pygments==2.19.1
-pytest==8.3.5
+Pygments==2.17.2
+pyparsing==2.4.7
+pytest==8.4.1
PyYAML==6.0.2
regex==2024.11.6
-requests==2.32.3
-restructuredtext_lint==1.4.0
+requests==2.32.4
+restructuredtext_lint==1.3.2
roman-numerals-py==3.1.0
-setuptools==80.3.1
-six==1.17.0
-snowballstemmer==3.0.0.1
+snowballstemmer==2.2.0
Sphinx==8.2.3
sphinx-copybutton==0.5.2
sphinx-lint==1.0.0
@@ -38,12 +34,11 @@ sphinx-tabs==3.4.7
sphinx_tamer==0.2.0
sphinxcontrib-applehelp==2.0.0
sphinxcontrib-devhelp==2.0.0
-sphinxcontrib-googleanalytics==0.4
sphinxcontrib-htmlhelp==2.1.0
sphinxcontrib-jquery==4.1
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-mermaid==1.0.0
sphinxcontrib-qthelp==2.0.0
-sphinxcontrib-serializinghtml==2.0.0
-stevedore==5.4.1
-urllib3==2.4.0
+sphinxcontrib-serializinghtml==1.1.10
+stevedore==3.5.0
+urllib3==1.26.5
@christophebedard some open questions from my side. Happy if you could have a look? |
I will take a look once I'm back from vacation on Tuesday-ish! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I have some comments and suggestions.
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]>
Signed-off-by: Nils-Christian Iseke <[email protected]>
Signed-off-by: Nils-Christian Iseke <[email protected]>
Signed-off-by: Nils-Christian Iseke <[email protected]>
Thank you @christophebedard ! |
Signed-off-by: Nils-Christian Iseke <[email protected]>
Signed-off-by: Nils-Christian Iseke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR. a couple of comments.
from my end, I think we just need to clarify how the |
Use noble for CI.